Changeset 194560 in webkit

Timestamp:

Jan 4, 2016 2:53:57 PM (8 years ago)

Author:

mark.lam@apple.com

Message:

isUntypedSpeculationForArithmetic is wrong.
​https://bugs.webkit.org/show_bug.cgi?id=152708

Reviewed by Filip Pizlo.

The isUntypedSpeculation...() checks should return true is we ever see
non-numeric types, regardless of whether numeric types are seen or not.
Previously, they only return true if we only see non-numeric types, and false if
we ever see numeric types.

This patch is perf neutral on both x86_64 and x86.

• bytecode/SpeculatedType.h:

(JSC::isUntypedSpeculationForArithmetic):
(JSC::isUntypedSpeculationForBitOps):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/SpeculatedType.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-01-04  Mark Lam  <mark.lam@apple.com>
+
+        isUntypedSpeculationForArithmetic is wrong.
+        https://bugs.webkit.org/show_bug.cgi?id=152708
+
+        Reviewed by Filip Pizlo.
+
+        The isUntypedSpeculation...() checks should return true is we ever see
+        non-numeric types, regardless of whether numeric types are seen or not.
+        Previously, they only return true if we only see non-numeric types, and false if
+        we ever see numeric types.
+
+        This patch is perf neutral on both x86_64 and x86.
+
+        * bytecode/SpeculatedType.h:
+        (JSC::isUntypedSpeculationForArithmetic):
+        (JSC::isUntypedSpeculationForBitOps):
+
 2016-01-04  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/JavaScriptCore/bytecode/SpeculatedType.h

@@ -388 +388 @@
 inline bool isUntypedSpeculationForArithmetic(SpeculatedType value)
 {
-    return !(value & (SpecFullNumber | SpecBoolean));
+    return !!(value & ~(SpecFullNumber | SpecBoolean));
 }
 
 inline bool isUntypedSpeculationForBitOps(SpeculatedType value)
 {
-    return !(value & (SpecFullNumber | SpecBoolean | SpecOther));
+    return !!(value & ~(SpecFullNumber | SpecBoolean | SpecOther));
 }