Changeset 197817 in webkit

Timestamp:

Mar 8, 2016, 4:21:26 PM (9 years ago)

Author:

mark.lam@apple.com

Message:

Implement Function.name support for getters/setters and inferring name of function properties.
​https://bugs.webkit.org/show_bug.cgi?id=154865

Rubber-stamped by Joseph Pecoraro.

Follow up to the fix for this bug: adding a few small clean-ups for issues Joe
pointed out in the bug.

• runtime/JSBoundSlotBaseFunction.cpp:

(JSC::JSBoundSlotBaseFunction::create):

• runtime/JSCJSValue.cpp:

(JSC::JSValue::putToPrimitiveByIndex):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSBoundSlotBaseFunction.cpp (modified) (1 diff)
• runtime/JSCJSValue.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-03-08  Mark Lam  <mark.lam@apple.com>
+
+        Implement Function.name support for getters/setters and inferring name of function properties.
+        https://bugs.webkit.org/show_bug.cgi?id=154865
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        Follow up to the fix for this bug: adding a few small clean-ups for issues Joe
+        pointed out in the bug.
+
+        * runtime/JSBoundSlotBaseFunction.cpp:
+        (JSC::JSBoundSlotBaseFunction::create):
+        * runtime/JSCJSValue.cpp:
+        (JSC::JSValue::putToPrimitiveByIndex):
+
 2016-03-08  Oliver Hunt  <oliver@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSBoundSlotBaseFunction.cpp

@@ -68 +68 @@
 
     // Can't do this during initialization because getHostFunction might do a GC allocation.
-    String prefix = (type == Type::Getter) ? "get " : "set ";
+    const char* prefix = (type == Type::Getter) ? "get " : "set ";
     function->finishCreation(vm, executable, boundSlotBase, getterSetter, makeString(prefix, name));
     return function;

trunk/Source/JavaScriptCore/runtime/JSCJSValue.cpp

@@ -208 +208 @@
         return;
     
-    if (shouldThrow && !exec->hadException())
     if (shouldThrow)
         throwTypeError(exec, StrictModeReadonlyPropertyWriteError);