Changeset 199745 in webkit

Timestamp:

Apr 19, 2016 4:31:25 PM (8 years ago)

Author:

mark.lam@apple.com

Message:

Replace $vm.printValue() with $vm.value().
​https://bugs.webkit.org/show_bug.cgi?id=156767

Reviewed by Saam Barati.

When debugging with $vm, this change allows us to do this:

$vm.print("myObj = " + $vm.value(myObj) + "\n");

... instead of having to do this:

$vm.print("myObj = ");
$vm.printValue(myObj);
$vm.print("\n");

• tools/JSDollarVMPrototype.cpp:

(JSC::JSDollarVMPrototype::printValue):
(JSC::functionValue):
(JSC::JSDollarVMPrototype::finishCreation):
(JSC::functionPrintValue): Deleted.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• tools/JSDollarVMPrototype.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-04-19  Mark Lam  <mark.lam@apple.com>
+
+        Replace $vm.printValue() with $vm.value().
+        https://bugs.webkit.org/show_bug.cgi?id=156767
+
+        Reviewed by Saam Barati.
+
+        When debugging with $vm, this change allows us to do this:
+
+            $vm.print("myObj = " + $vm.value(myObj) + "\n");
+
+        ... instead of having to do this:
+
+            $vm.print("myObj = ");
+            $vm.printValue(myObj);
+            $vm.print("\n");
+
+        * tools/JSDollarVMPrototype.cpp:
+        (JSC::JSDollarVMPrototype::printValue):
+        (JSC::functionValue):
+        (JSC::JSDollarVMPrototype::finishCreation):
+        (JSC::functionPrintValue): Deleted.
+
 2016-04-18  Oliver Hunt  <oliver@apple.com>
 

trunk/Source/JavaScriptCore/tools/JSDollarVMPrototype.cpp

@@ -34 +34 @@
 #include "StackVisitor.h"
 #include <wtf/DataLog.h>
+#include <wtf/StringPrintStream.h>
 
 namespace JSC {
@@ -389 +390 @@
 }
 
-static EncodedJSValue JSC_HOST_CALL functionPrintValue(ExecState* exec)
-{
+static EncodedJSValue JSC_HOST_CALL functionValue(ExecState* exec)
+{
+    WTF::StringPrintStream stream;
     for (unsigned i = 0; i < exec->argumentCount(); ++i) {
         if (i)
-            dataLog(" ");
-        dataLog(exec->uncheckedArgument(i));
-    }
-    return JSValue::encode(jsUndefined());
+            stream.print(", ");
+        stream.print(exec->uncheckedArgument(i));
+    }
+    
+    return JSValue::encode(jsString(exec, stream.toString()));
 }
 
@@ -421 +424 @@
     addFunction(vm, globalObject, "printStack", functionPrintStack, 0);
 
-    addFunction(vm, globalObject, "printValue", functionPrintValue, 1);
+    addFunction(vm, globalObject, "value", functionValue, 1);
 }