Changeset 200504 in webkit

Timestamp:

May 5, 2016 7:40:50 PM (8 years ago)

Author:

ap@apple.com

Message:

Improve HTTP test names in WebKitTestRunner's crash report information
​https://bugs.webkit.org/show_bug.cgi?id=157389

Reviewed by Alex Christensen.

• WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:

(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.

• WebKitTestRunner/cocoa/CrashReporterInfo.mm:

(WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
use other port numbers too. For http tests, return the complete URL string, not
just the path.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm (modified) (1 diff)
• WebKitTestRunner/cocoa/CrashReporterInfo.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-05-05  Alexey Proskuryakov  <ap@apple.com>
+
+        Improve HTTP test names in WebKitTestRunner's crash report information
+        https://bugs.webkit.org/show_bug.cgi?id=157389
+
+        Reviewed by Alex Christensen.
+
+        * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
+        (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
+
+        * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
+        (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
+        use other port numbers too. For http tests, return the complete URL string, not
+        just the path.
+
 2016-05-04  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm

@@ -43 +43 @@
         return;
 
+    // FIXME: We should not be changing test URL every time the test navigates. The current URL could be
+    // aditional information, but it shouldn't replace the initial test URL.
     setCrashReportApplicationSpecificInformationToURL(InjectedBundle::singleton().testRunner()->testURL());
 }

trunk/Tools/WebKitTestRunner/cocoa/CrashReporterInfo.mm

@@ -34 +34 @@
 namespace WTR {
 
-static String testPathFromURL(WKURLRef url)
+static String testDescription(WKURLRef url)
 {
     RetainPtr<CFURLRef> cfURL = adoptCF(WKURLCopyCFURL(kCFAllocatorDefault, url));
@@ -60 +60 @@
     RetainPtr<CFStringRef> hostCFString = adoptCF(CFURLCopyHostName(cfURL.get()));
     String hostString(hostCFString.get());
-    if (hostString == "127.0.0.1"  && (CFURLGetPortNumber(cfURL.get()) == 8000 || CFURLGetPortNumber(cfURL.get()) == 8443))
-        return pathString;
+    if (hostString != "127.0.0.1")
+        return String();
 
-    return String();
+    return CFURLGetString(cfURL.get());
 }
 
 void setCrashReportApplicationSpecificInformationToURL(WKURLRef url)
 {
-    String testPath = testPathFromURL(url);
-    if (!testPath.isNull()) {
+    String description = testDescription(url);
+    if (!description.isNull()) {
         String message("CRASHING TEST: ");
-        message = message + testPath;
+        message = message + description;
         WKSetCrashReportApplicationSpecificInformation(message.createCFString().get());
     }