Changeset 201733 in webkit


Ignore:
Timestamp:
Jun 6, 2016 5:00:55 PM (8 years ago)
Author:
mark.lam@apple.com
Message:

32-bit JSC stress test failing: stress/recursive-try-catch.js.ftl-no-cjit-validate-sampling-profiler
https://bugs.webkit.org/show_bug.cgi?id=158362

Reviewed by Michael Saboff.

The test does infinite recursion until it overflows the stack. That means the
sampling profiler will have to capture excessively large samples, which in turn
makes it run very slowly. This is what causes the test time out.

The fix is to not run the test with the sampling profiler.

  • tests/stress/recursive-try-catch.js:
Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r201732 r201733  
     12016-06-06  Mark Lam  <mark.lam@apple.com>
     2
     3        32-bit JSC stress test failing: stress/recursive-try-catch.js.ftl-no-cjit-validate-sampling-profiler
     4        https://bugs.webkit.org/show_bug.cgi?id=158362
     5
     6        Reviewed by Michael Saboff.
     7
     8        The test does infinite recursion until it overflows the stack.  That means the
     9        sampling profiler will have to capture excessively large samples, which in turn
     10        makes it run very slowly.  This is what causes the test time out.
     11
     12        The fix is to not run the test with the sampling profiler.
     13
     14        * tests/stress/recursive-try-catch.js:
     15
    1162016-06-06  Andreas Kling  <akling@apple.com>
    217
  • trunk/Source/JavaScriptCore/tests/stress/recursive-try-catch.js

    r201589 r201733  
     1//@ defaultNoSamplingProfilerRun
    12// This test should run to completion without excessive memory usage
    23
Note: See TracChangeset for help on using the changeset viewer.