Changeset 202390 in webkit

Timestamp:

Jun 23, 2016 12:17:49 PM (8 years ago)

Author:

ap@apple.com

Message:

Handle (0, 0) ranges from Lookup
​https://bugs.webkit.org/show_bug.cgi?id=159062
rdar://problem/26960385

Reviewed by Tim Horton.

Source/WebCore:

• editing/mac/DictionaryLookup.mm: (WebCore::DictionaryLookup::rangeAtHitTestResult):

Paper over <​https://bugs.webkit.org/show_bug.cgi?id=159063>, which seems too involved
to fix now.

LayoutTests:

• platform/mac/TestExpectations: Unmark the test that was broken due to this.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/editing/mac/DictionaryLookup.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-06-23  Alexey Proskuryakov  <ap@apple.com>
+
+        Handle (0, 0) ranges from Lookup
+        https://bugs.webkit.org/show_bug.cgi?id=159062
+        rdar://problem/26960385
+
+        Reviewed by Tim Horton.
+
+        * platform/mac/TestExpectations: Unmark the test that was broken due to this.
+
 2016-06-23  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1441 +1441 @@
 # rdar://problem/26950065
 [ Sierra+ ] editing/mac/input/unconfirmed-text-navigation-with-page-cache.html [ Skip ]
-
-# rdar://problem/26960385
-[ Sierra+ ] editing/mac/dictionary-lookup/dictionary-lookup-input.html [ Failure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-23  Alexey Proskuryakov  <ap@apple.com>
+
+        Handle (0, 0) ranges from Lookup
+        https://bugs.webkit.org/show_bug.cgi?id=159062
+        rdar://problem/26960385
+
+        Reviewed by Tim Horton.
+
+        * editing/mac/DictionaryLookup.mm: (WebCore::DictionaryLookup::rangeAtHitTestResult):
+        Paper over <https://bugs.webkit.org/show_bug.cgi?id=159063>, which seems too involved
+        to fix now.
+
 2016-06-23  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/editing/mac/DictionaryLookup.mm

@@ -142 +142 @@
 
     // This function sometimes returns {NSNotFound, 0} if it was unable to determine a good string.
-    if (extractedRange.location == NSNotFound)
+    // FIXME (159063): We shouldn't need to check for zero length here.
+    if (extractedRange.location == NSNotFound || extractedRange.length == 0)
         return nullptr;