Changeset 205917 in webkit

Timestamp:

Sep 14, 2016, 10:55:15 AM (9 years ago)

Author:

mark.lam@apple.com

Message:

Use Options::validateExceptionChecks() instead of VM::m_verifyExceptionEvents.
​https://bugs.webkit.org/show_bug.cgi?id=161975

Reviewed by Keith Miller.

This makes it less burdensome (no longer needs a rebuild to enable checks) to do
incremental work towards enabling checks all the time.

• runtime/Options.h:
• runtime/VM.cpp:

(JSC::VM::verifyExceptionCheckNeedIsSatisfied):

• runtime/VM.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/Options.h (modified) (1 diff)
• runtime/VM.cpp (modified) (1 diff)
• runtime/VM.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-09-14  Mark Lam  <mark.lam@apple.com>
+
+        Use Options::validateExceptionChecks() instead of VM::m_verifyExceptionEvents.
+        https://bugs.webkit.org/show_bug.cgi?id=161975
+
+        Reviewed by Keith Miller.
+
+        This makes it less burdensome (no longer needs a rebuild to enable checks) to do
+        incremental work towards enabling checks all the time.
+
+        * runtime/Options.h:
+        * runtime/VM.cpp:
+        (JSC::VM::verifyExceptionCheckNeedIsSatisfied):
+        * runtime/VM.h:
+
 2016-09-14  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/runtime/Options.h

@@ -348 +348 @@
     v(bool, validateDFGExceptionHandling, false, Normal, "Causes the DFG to emit code validating exception handling for each node that can exit") /* This is true by default on Debug builds */\
     v(bool, dumpSimulatedThrows, false, Normal, "Dumps the call stack at each simulated throw for exception scope verification") \
+    v(bool, validateExceptionChecks, false, Normal, "Verifies that needed exception checks are performed.") \
     \
     v(bool, useExecutableAllocationFuzz, false, Normal, nullptr) \

trunk/Source/JavaScriptCore/runtime/VM.cpp

@@ -897 +897 @@
 void VM::verifyExceptionCheckNeedIsSatisfied(unsigned recursionDepth, ExceptionEventLocation& location)
 {
-    if (!m_verifyExceptionEvents)
+    if (!Options::validateExceptionChecks())
         return;
 

trunk/Source/JavaScriptCore/runtime/VM.h

@@ -704 +704 @@
     unsigned m_simulatedThrowPointRecursionDepth { 0 };
     mutable bool m_needExceptionCheck { false };
-
-    // Disabled temporarily until all known verification failures are fixed.
-    bool m_verifyExceptionEvents { false };
 #endif