Changeset 210569 in webkit

Timestamp:

Jan 10, 2017 5:28:00 PM (7 years ago)

Author:

mark.lam@apple.com

Message:

Reverting run-jsc-stress-tests' $buildType to use string values.
​https://bugs.webkit.org/show_bug.cgi?id=166912

Rubber stamped by Filip Pizlo.

This is so that we can test for it in the tests e.g.
@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end

• Scripts/run-jsc-stress-tests:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-jsc-stress-tests (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-01-10  Mark Lam  <mark.lam@apple.com>
+
+        Reverting run-jsc-stress-tests' $buildType to use string values.
+        https://bugs.webkit.org/show_bug.cgi?id=166912
+
+        Rubber stamped by Filip Pizlo.
+
+        This is so that we can test for it in the tests e.g.
+        //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
+
+        * Scripts/run-jsc-stress-tests:
+
 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Tools/Scripts/run-jsc-stress-tests

@@ -118 +118 @@
 $envVars = []
 $quickMode = false
-$buildType = :release
+$buildType = "release"
 $forceCollectContinuously = false
 
@@ -232 +232 @@
         $quickMode = true
     when '--debug'
-        $buildType = :debug
+        $buildType = "debug"
     when '--release'
-        $buildType = :release
+        $buildType = "release"
     end
 }
@@ -258 +258 @@
     # If we're not provided a JSC path, try to come up with a sensible JSC path automagically.
     command = SCRIPTS_PATH.join("webkit-build-directory").to_s
-    command += ($buildType == :release) ? " --release" : " --debug"
+    command += ($buildType == "release") ? " --release" : " --debug"
     command += " --executablePath"
 
@@ -432 +432 @@
 
 def shouldCollectContinuously?
-    $buildType == :release or $forceCollectContinuously
+    $buildType == "release" or $forceCollectContinuously
 end