Changeset 211835 in webkit


Ignore:
Timestamp:
Feb 7, 2017 1:29:50 PM (7 years ago)
Author:
achristensen@apple.com
Message:

Revert r166597
​https://bugs.webkit.org/show_bug.cgi?id=167951

Reviewed by Andreas Kling.

Source/WebCore:

  • platform/spi/cf/CFNetworkSPI.h:

Remove now-unused SPI declaration.

Source/WebKit2:

CFURLConnectionInvalidateConnectionCache is not commonly called and is likely causing
CFNetwork to be in a strange state when using NSURLSession and invalidating the connection
cache during authentication, especially server trust evaluation. Right now we only call
it when handling memory pressure, and it isn't worth getting into such a strange state
in a poorly tested situation. See rdar://problem/27439617

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::lowMemoryHandler):
(WebKit::NetworkProcess::initializeSandbox):
(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.

Location:
trunk/Source
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r211832 r211835  
     12017-02-07  Alex Christensen  <achristensen@webkit.org>
     2
     3        Revert r166597
     4        https://bugs.webkit.org/show_bug.cgi?id=167951
     5
     6        Reviewed by Andreas Kling.
     7
     8        * platform/spi/cf/CFNetworkSPI.h:
     9        Remove now-unused SPI declaration.
     10
    1112017-02-07  Sam Weinig  <sam@webkit.org>
    212

  • trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h

    r210467 r211835  
    155155#endif
    156156#endif // PLATFORM(COCOA)
    157 
    158 void CFURLConnectionInvalidateConnectionCache();
    159157
    160158extern CFStringRef const kCFHTTPCookieLocalFileDomain;

  • trunk/Source/WebKit2/ChangeLog

    r211831 r211835  
     12017-02-07  Alex Christensen  <achristensen@webkit.org>
     2
     3        Revert r166597
     4        https://bugs.webkit.org/show_bug.cgi?id=167951
     5
     6        Reviewed by Andreas Kling.
     7
     8        CFURLConnectionInvalidateConnectionCache is not commonly called and is likely causing
     9        CFNetwork to be in a strange state when using NSURLSession and invalidating the connection
     10        cache during authentication, especially server trust evaluation.  Right now we only call
     11        it when handling memory pressure, and it isn't worth getting into such a strange state
     12        in a poorly tested situation. See rdar://problem/27439617
     13
     14        * NetworkProcess/NetworkProcess.cpp:
     15        (WebKit::NetworkProcess::lowMemoryHandler):
     16        (WebKit::NetworkProcess::initializeSandbox):
     17        (WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
     18        * NetworkProcess/NetworkProcess.h:
     19        * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
     20        (WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
     21
    1222017-02-07  Brian Burg  <bburg@apple.com>
    223

  • trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp

    r211747 r211835  
    196196        return;
    197197
    198     platformLowMemoryHandler(critical);
    199198    WTF::releaseFastMallocFreeMemory();
    200199}
    … …  
    656655{
    657656}
    658 
    659 void NetworkProcess::platformLowMemoryHandler(Critical)
    660 {
    661 }
    662657#endif
    663658

  • trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h

    r211747 r211835  
    129129
    130130    void lowMemoryHandler(WebCore::Critical);
    131     void platformLowMemoryHandler(WebCore::Critical);
    132131
    133132    // ChildProcess

  • trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm

    r208556 r211835  
    4444namespace WebKit {
    4545
    46 void NetworkProcess::platformLowMemoryHandler(WebCore::Critical)
    47 {
    48     CFURLConnectionInvalidateConnectionCache();
    49 }
    50 
    5146static void initializeNetworkSettings()
    5247{
Note: See TracChangeset for help on using the changeset viewer.