Changeset 214238 in webkit

Timestamp:

Mar 21, 2017 5:45:15 PM (7 years ago)

Author:

aakash_jain@apple.com

Message:

EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade
​https://bugs.webkit.org/show_bug.cgi?id=169937
<rdar://problem/31181859>

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._parse_bug_id_from_attachment_page): Since rel tag is no longer present, parsing the bug id from bug_title.

• Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fixed unit test.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/net/bugzilla/bugzilla.py (modified) (1 diff)
• Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-03-21  Aakash Jain  <aakash_jain@apple.com>
+
+        EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade
+        https://bugs.webkit.org/show_bug.cgi?id=169937
+        <rdar://problem/31181859>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+        (Bugzilla._parse_bug_id_from_attachment_page): Since rel tag is no longer present, parsing the bug id from bug_title. 
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fixed unit test.
+
 2017-03-21  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py

@@ -487 +487 @@
     def _parse_bug_id_from_attachment_page(self, page):
         # The "Up" relation happens to point to the bug.
-        up_link = BeautifulSoup(page).find('link', rel='Up')
-        if not up_link:
+        title = BeautifulSoup(page).find('div', attrs={'id':'bug_title'})
+        if not title :
             _log.warning("This attachment does not exist (or you don't have permissions to view it).")
             return None
-        match = re.search("show_bug.cgi\?id=(?P<bug_id>\d+)", up_link['href'])
+        match = re.search("show_bug.cgi\?id=(?P<bug_id>\d+)", str(title))
+        if not match:
+            _log.warning("Unable to parse bug id from attachment")
+            return None
         return int(match.group('bug_id'))
 

trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py

@@ -239 +239 @@
     <title>
   Attachment 41073 Details for Bug 27314</title>
-<link rel="Top" href="https://bugs.webkit.org/">
-    <link rel="Up" href="show_bug.cgi?id=27314">
+<div id="bug_title">
+  Attachment 41073 Details for
+  <a class="bz_bug_link bz_status_ASSIGNED " title="Sample bug" href="show_bug.cgi?id=27314">Bug 27314</a>: Sample bug</div>
 """