Changeset 214626 in webkit

Timestamp:

Mar 30, 2017 2:35:39 PM (7 years ago)

Author:

Chris Dumez

Message:

svg/animations/animations-paused-in-background-page.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=170290

Reviewed by Simon Fraser.

Fix shouldBecomeEqual() check in the test which was wrong and was passing by chance
due to a race.

• svg/animations/animations-paused-in-background-page-expected.txt:
• svg/animations/animations-paused-in-background-page.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• svg/animations/animations-paused-in-background-page-expected.txt (modified) (1 diff)
• svg/animations/animations-paused-in-background-page.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-03-30  Chris Dumez  <cdumez@apple.com>
+
+        svg/animations/animations-paused-in-background-page.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=170290
+
+        Reviewed by Simon Fraser.
+
+        Fix shouldBecomeEqual() check in the test which was wrong and was passing by chance
+        due to a race.
+
+        * svg/animations/animations-paused-in-background-page-expected.txt:
+        * svg/animations/animations-paused-in-background-page.html:
+
 2017-03-30  Javier Fernandez  <jfernandez@igalia.com>
 

trunk/LayoutTests/svg/animations/animations-paused-in-background-page-expected.txt

@@ -8 +8 @@
 PASS internals.isImageAnimating(testImage) became false
 Setting page visibility to visible
-PASS internals.isImageAnimating(testImage) became false
+PASS internals.isImageAnimating(testImage) became true
 PASS successfullyParsed is true
 

trunk/LayoutTests/svg/animations/animations-paused-in-background-page.html

@@ -12 +12 @@
     if (window.testRunner)
         testRunner.setPageVisibility('visible');
-    shouldBecomeEqual("internals.isImageAnimating(testImage)", "false", finishJSTest);
+    shouldBecomeEqual("internals.isImageAnimating(testImage)", "true", finishJSTest);
 }