Changeset 215535 in webkit

Timestamp:

Apr 19, 2017, 3:27:04 PM (8 years ago)

Author:

achristensen@apple.com

Message:

Parsing large XML strings fails
​https://bugs.webkit.org/show_bug.cgi?id=170999
<rdar://problem/17336267>

Reviewed by Brady Eidson.

Source/WebCore:

Test: fast/dom/xml-large.html

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLParserContext::createStringParser):
(WebCore::XMLParserContext::createMemoryParser):
Allow huge XML strings. They work fine in Chrome and Firefox.

LayoutTests:

• fast/dom/xml-large-expected.txt: Added.
• fast/dom/xml-large.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/xml-large-expected.txt (added)
• LayoutTests/fast/dom/xml-large.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-04-19  Alex Christensen  <achristensen@webkit.org>
+
+        Parsing large XML strings fails
+        https://bugs.webkit.org/show_bug.cgi?id=170999
+        <rdar://problem/17336267>
+
+        Reviewed by Brady Eidson.
+
+        * fast/dom/xml-large-expected.txt: Added.
+        * fast/dom/xml-large.html: Added.
+
 2017-04-19  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-04-19  Alex Christensen  <achristensen@webkit.org>
+
+        Parsing large XML strings fails
+        https://bugs.webkit.org/show_bug.cgi?id=170999
+        <rdar://problem/17336267>
+
+        Reviewed by Brady Eidson.
+
+        Test: fast/dom/xml-large.html
+
+        * xml/parser/XMLDocumentParserLibxml2.cpp:
+        (WebCore::XMLParserContext::createStringParser):
+        (WebCore::XMLParserContext::createMemoryParser):
+        Allow huge XML strings. They work fine in Chrome and Firefox.
+
 2017-04-19  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp

@@ -512 +512 @@
 
     // Substitute entities.
-    xmlCtxtUseOptions(parser, XML_PARSE_NOENT);
+    xmlCtxtUseOptions(parser, XML_PARSE_NOENT | XML_PARSE_HUGE);
 
     switchToUTF16(parser);
@@ -541 +541 @@
     // Substitute entities.
     // FIXME: Why is XML_PARSE_NODICT needed? This is different from what createStringParser does.
-    xmlCtxtUseOptions(parser, XML_PARSE_NODICT | XML_PARSE_NOENT);
+    xmlCtxtUseOptions(parser, XML_PARSE_NODICT | XML_PARSE_NOENT | XML_PARSE_HUGE);
 
     // Internal initialization