Changeset 216231 in webkit

Timestamp:

May 4, 2017, 8:24:55 PM (8 years ago)

Author:

mark.lam@apple.com

Message:

API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
​https://bugs.webkit.org/show_bug.cgi?id=171702

Reviewed by Filip Pizlo.

The test was supposed to use the MAKE_STATIC_STRING_IMPL macro. I had previously
changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
confirm that the test will detect a regression. Unfortunately, I forgot to
change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
This patch fixes that.

• TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::neverDestroyedString):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WTF/StringImpl.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-05-04  Mark Lam  <mark.lam@apple.com>
+
+        API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
+        https://bugs.webkit.org/show_bug.cgi?id=171702
+
+        Reviewed by Filip Pizlo.
+
+        The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
+        changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
+        confirm that the test will detect a regression.  Unfortunately, I forgot to
+        change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
+        This patch fixes that.
+
+        * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
+        (TestWebKitAPI::neverDestroyedString):
+
 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp

@@ -630 +630 @@
 static const String& neverDestroyedString()
 {
-    static NeverDestroyed<String> str(StaticStringImpl("NeverDestroyedString"));
+    static NeverDestroyed<String> str(MAKE_STATIC_STRING_IMPL("NeverDestroyedString"));
     return str;
 };