Changeset 217498 in webkit

Timestamp:

May 26, 2017, 11:45:43 AM (8 years ago)

Author:

mark.lam@apple.com

Message:

REGRESSION(216914): testCFStrings encounters an invalid ExecState callee pointer.
​https://bugs.webkit.org/show_bug.cgi?id=172651

Reviewed by Saam Barati.

This is because the assertion utility functions used in testCFStrings() expects
to get the JSGlobalContextRef from the global context variable. However,
testCFStrings() creates its own JSGlobalContextRef but does not set the global
context variable to it.

The fix is to make testCFStrings() initialize the global context variable properly.

• API/tests/testapi.c:

(testCFStrings):

Location:

trunk/Source/JavaScriptCore

Files:

• API/tests/testapi.c (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/API/tests/testapi.c ¶

@@ -1240 +1240 @@
 static void testCFStrings(void)
 {
-    JSGlobalContextRef context = JSGlobalContextCreate(0);
+    /* The assertion utility functions we use below expects to get the JSGlobalContextRef
+       from the global context variable. */
+    JSGlobalContextRef oldContext = context;
+    context = JSGlobalContextCreate(0);
 
     UniChar singleUniChar = 65; // Capital A
@@ -1333 +1336 @@
 
     JSGlobalContextRelease(context);
+    context = oldContext;
 }
 #endif

trunk/Source/JavaScriptCore/ChangeLog ¶

@@ +1 @@
+2017-05-26  Mark Lam  <mark.lam@apple.com>
+
+        REGRESSION(216914): testCFStrings encounters an invalid ExecState callee pointer.
+        https://bugs.webkit.org/show_bug.cgi?id=172651
+
+        Reviewed by Saam Barati.
+
+        This is because the assertion utility functions used in testCFStrings() expects
+        to get the JSGlobalContextRef from the global context variable.  However,
+        testCFStrings() creates its own JSGlobalContextRef but does not set the global
+        context variable to it.
+
+        The fix is to make testCFStrings() initialize the global context variable properly.
+
+        * API/tests/testapi.c:
+        (testCFStrings):
+
 2017-05-26  Yusuke Suzuki  <utatane.tea@gmail.com>