Changeset 218416 in webkit

Timestamp:

Jun 16, 2017 2:43:00 PM (7 years ago)

Author:

achristensen@apple.com

Message:

REGRESSION (r213126): Sync XHR needs partition for cache and credentials
​https://bugs.webkit.org/show_bug.cgi?id=173496
<rdar://problem/31943596>

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/security/sync-xhr-partition.html

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

LayoutTests:

• http/tests/security/sync-xhr-partition-expected.txt: Added.
• http/tests/security/sync-xhr-partition.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/security/sync-xhr-partition-expected.txt (added)
• LayoutTests/http/tests/security/sync-xhr-partition.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/xml/XMLHttpRequest.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-06-16  Alex Christensen  <achristensen@webkit.org>
+
+        REGRESSION (r213126): Sync XHR needs partition for cache and credentials
+        https://bugs.webkit.org/show_bug.cgi?id=173496
+        <rdar://problem/31943596>
+
+        Reviewed by Darin Adler.
+
+        * http/tests/security/sync-xhr-partition-expected.txt: Added.
+        * http/tests/security/sync-xhr-partition.html: Added.
+
 2017-06-16  Matt Lewis  <jlewis3@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-06-16  Alex Christensen  <achristensen@webkit.org>
+
+        REGRESSION (r213126): Sync XHR needs partition for cache and credentials
+        https://bugs.webkit.org/show_bug.cgi?id=173496
+        <rdar://problem/31943596>
+
+        Reviewed by Darin Adler.
+
+        Test: http/tests/security/sync-xhr-partition.html
+
+        * xml/XMLHttpRequest.cpp:
+        (WebCore::XMLHttpRequest::createRequest):
+
 2017-06-16  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/xml/XMLHttpRequest.cpp

@@ -761 +761 @@
             setPendingActivity(this);
     } else {
+        request.setDomainForCachePartition(scriptExecutionContext()->topOrigin().domainForCachePartition());
         InspectorInstrumentation::willLoadXHRSynchronously(scriptExecutionContext());
         ThreadableLoader::loadResourceSynchronously(*scriptExecutionContext(), WTFMove(request), *this, options);