Changeset 221022 in webkit


Ignore:
Timestamp:
Aug 22, 2017, 10:38:14 AM (8 years ago)
Author:
achristensen@apple.com
Message:

Remove ChromeClient::hasOpenedPopup
​https://bugs.webkit.org/show_bug.cgi?id=175804

Reviewed by Sam Weinig.

Source/WebCore:

No change in behavior. All implementations just returned false.

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::hasOpenedPopup const): Deleted.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • rendering/RenderMenuList.cpp:

(RenderMenuList::showPopup):

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::hasOpenedPopup const): Deleted.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::hasOpenedPopup const): Deleted.

Source/WebKitLegacy/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::hasOpenedPopup const): Deleted.

  • WebCoreSupport/WebChromeClient.h:
Location:
trunk/Source
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r221020 r221022  
     12017-08-22  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove ChromeClient::hasOpenedPopup
     4        https://bugs.webkit.org/show_bug.cgi?id=175804
     5
     6        Reviewed by Sam Weinig.
     7
     8        No change in behavior.  All implementations just returned false.
     9
     10        * loader/EmptyClients.h:
     11        * page/Chrome.cpp:
     12        (WebCore::Chrome::hasOpenedPopup const): Deleted.
     13        * page/Chrome.h:
     14        * page/ChromeClient.h:
     15        * rendering/RenderMenuList.cpp:
     16        (RenderMenuList::showPopup):
     17
    1182017-08-22  Andy Estes  <aestes@apple.com>
    219

  • trunk/Source/WebCore/loader/EmptyClients.h

    r217862 r221022  
    9595    bool selectItemWritingDirectionIsNatural() final { return false; }
    9696    bool selectItemAlignmentFollowsMenuWritingDirection() final { return false; }
    97     bool hasOpenedPopup() const final { return false; }
    9897    RefPtr<PopupMenu> createPopupMenu(PopupMenuClient&) const final;
    9998    RefPtr<SearchPopupMenu> createSearchPopupMenu(PopupMenuClient&) const final;

  • trunk/Source/WebCore/page/Chrome.cpp

    r217862 r221022  
    522522}
    523523
    524 bool Chrome::hasOpenedPopup() const
    525 {
    526     return m_client.hasOpenedPopup();
    527 }
    528 
    529524RefPtr<PopupMenu> Chrome::createPopupMenu(PopupMenuClient& client) const
    530525{

  • trunk/Source/WebCore/page/Chrome.h

    r218665 r221022  
    168168    bool selectItemWritingDirectionIsNatural();
    169169    bool selectItemAlignmentFollowsMenuWritingDirection();
    170     bool hasOpenedPopup() const;
    171170    RefPtr<PopupMenu> createPopupMenu(PopupMenuClient&) const;
    172171    RefPtr<SearchPopupMenu> createSearchPopupMenu(PopupMenuClient&) const;

  • trunk/Source/WebCore/page/ChromeClient.h

    r218665 r221022  
    382382    virtual bool selectItemAlignmentFollowsMenuWritingDirection() = 0;
    383383    // Checks if there is an opened popup, called by RenderMenuList::showPopup().
    384     virtual bool hasOpenedPopup() const = 0;
    385384    virtual RefPtr<PopupMenu> createPopupMenu(PopupMenuClient&) const = 0;
    386385    virtual RefPtr<SearchPopupMenu> createSearchPopupMenu(PopupMenuClient&) const = 0;

  • trunk/Source/WebCore/rendering/RenderMenuList.cpp

    r214173 r221022  
    371371        return;
    372372
    373     if (document().page()->chrome().hasOpenedPopup())
    374         return;
    375 
    376373    // Create m_innerBlock here so it ends up as the first child.
    377374    // This is important because otherwise we might try to create m_innerBlock

  • trunk/Source/WebKit/ChangeLog

    r221017 r221022  
     12017-08-22  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove ChromeClient::hasOpenedPopup
     4        https://bugs.webkit.org/show_bug.cgi?id=175804
     5
     6        Reviewed by Sam Weinig.
     7
     8        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
     9        (WebKit::WebChromeClient::hasOpenedPopup const): Deleted.
     10        * WebProcess/WebCoreSupport/WebChromeClient.h:
     11
    1122017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
    213

  • trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp

    r219996 r221022  
    829829}
    830830
    831 bool WebChromeClient::hasOpenedPopup() const
    832 {
    833     notImplemented();
    834     return false;
    835 }
    836 
    837831RefPtr<PopupMenu> WebChromeClient::createPopupMenu(PopupMenuClient& client) const
    838832{

  • trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h

    r218535 r221022  
    200200    bool selectItemWritingDirectionIsNatural() final;
    201201    bool selectItemAlignmentFollowsMenuWritingDirection() final;
    202     bool hasOpenedPopup() const final;
    203202    RefPtr<WebCore::PopupMenu> createPopupMenu(WebCore::PopupMenuClient&) const final;
    204203    RefPtr<WebCore::SearchPopupMenu> createSearchPopupMenu(WebCore::PopupMenuClient&) const final;

  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r221017 r221022  
     12017-08-22  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove ChromeClient::hasOpenedPopup
     4        https://bugs.webkit.org/show_bug.cgi?id=175804
     5
     6        Reviewed by Sam Weinig.
     7
     8        * WebCoreSupport/WebChromeClient.h:
     9        * WebCoreSupport/WebChromeClient.mm:
     10        (WebChromeClient::hasOpenedPopup const): Deleted.
     11
    1122017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
    213

  • trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h

    r216245 r221022  
    199199    bool selectItemWritingDirectionIsNatural() override;
    200200    bool selectItemAlignmentFollowsMenuWritingDirection() override;
    201     bool hasOpenedPopup() const final;
    202201    RefPtr<WebCore::PopupMenu> createPopupMenu(WebCore::PopupMenuClient&) const override;
    203202    RefPtr<WebCore::SearchPopupMenu> createSearchPopupMenu(WebCore::PopupMenuClient&) const override;

  • trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm

    r216816 r221022  
    877877}
    878878
    879 bool WebChromeClient::hasOpenedPopup() const
    880 {
    881     notImplemented();
    882     return false;
    883 }
    884 
    885879RefPtr<WebCore::PopupMenu> WebChromeClient::createPopupMenu(WebCore::PopupMenuClient& client) const
    886880{

  • trunk/Source/WebKitLegacy/win/ChangeLog

    r220930 r221022  
     12017-08-22  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove ChromeClient::hasOpenedPopup
     4        https://bugs.webkit.org/show_bug.cgi?id=175804
     5
     6        Reviewed by Sam Weinig.
     7
     8        * WebCoreSupport/WebChromeClient.cpp:
     9        (WebChromeClient::hasOpenedPopup const): Deleted.
     10        * WebCoreSupport/WebChromeClient.h:
     11
    1122017-08-18  Per Arne Vollan  <pvollan@apple.com>
    213

  • trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.cpp

    r216641 r221022  
    781781}
    782782
    783 bool WebChromeClient::hasOpenedPopup() const
    784 {
    785     notImplemented();
    786     return false;
    787 }
    788 
    789783RefPtr<PopupMenu> WebChromeClient::createPopupMenu(PopupMenuClient& client) const
    790784{

  • trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h

    r216823 r221022  
    151151    bool selectItemWritingDirectionIsNatural() final;
    152152    bool selectItemAlignmentFollowsMenuWritingDirection() final;
    153     bool hasOpenedPopup() const final;
    154153    RefPtr<WebCore::PopupMenu> createPopupMenu(WebCore::PopupMenuClient&) const final;
    155154    RefPtr<WebCore::SearchPopupMenu> createSearchPopupMenu(WebCore::PopupMenuClient&) const final;
Note: See TracChangeset for help on using the changeset viewer.