Changeset 221935 in webkit


Ignore:
Timestamp:
Sep 12, 2017 12:46:41 PM (7 years ago)
Author:
mark.lam@apple.com
Message:

REGRESSION: 3 stress/op_mod (and op_div) tests timing out on Debug JSC bots.
​https://bugs.webkit.org/show_bug.cgi?id=176630

Reviewed by JF Bastien.

Debug builds are just slow, and these tests do a lot. They pass when I run them
locally on my MacBook Pro. So, I'm bumping their timing multiplier to 2.0x as
a speculative fix for the bots that are seeing these fail.

I also undid the skipping of the op_mod tests for debug builds.

  • stress/op_div-ConstVar.js:
  • stress/op_div-VarConst.js:
  • stress/op_div-VarVar.js:
  • stress/op_mod-ConstVar.js:
  • stress/op_mod-VarConst.js:
  • stress/op_mod-VarVar.js:
Location:
trunk/JSTests
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/JSTests/ChangeLog

    r221919 r221935  
     12017-09-12  Mark Lam  <mark.lam@apple.com>
     2
     3        REGRESSION: 3 stress/op_mod (and op_div) tests timing out on Debug JSC bots.
     4        https://bugs.webkit.org/show_bug.cgi?id=176630
     5
     6        Reviewed by JF Bastien.
     7
     8        Debug builds are just slow, and these tests do a lot.  They pass when I run them
     9        locally on my MacBook Pro.  So, I'm bumping their timing multiplier to 2.0x as
     10        a speculative fix for the bots that are seeing these fail.
     11
     12        I also undid the skipping of the op_mod tests for debug builds.
     13
     14        * stress/op_div-ConstVar.js:
     15        * stress/op_div-VarConst.js:
     16        * stress/op_div-VarVar.js:
     17        * stress/op_mod-ConstVar.js:
     18        * stress/op_mod-VarConst.js:
     19        * stress/op_mod-VarVar.js:
     20
    1212017-09-12  Ryan Haddad  <ryanhaddad@apple.com>
    222

  • trunk/JSTests/stress/op_div-ConstVar.js

    r208925 r221935  
    1 //@ runFTLNoCJIT("--timeoutMultiplier=1.5")
     1//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
    22
    33// If all goes well, this test module will terminate silently. If not, it will print

  • trunk/JSTests/stress/op_div-VarConst.js

    r208925 r221935  
    1 //@ runFTLNoCJIT("--timeoutMultiplier=1.5")
     1//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
    22
    33// If all goes well, this test module will terminate silently. If not, it will print

  • trunk/JSTests/stress/op_div-VarVar.js

    r208925 r221935  
    1 //@ runFTLNoCJIT("--timeoutMultiplier=1.5")
     1//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
    22
    33// If all goes well, this test module will terminate silently. If not, it will print

  • trunk/JSTests/stress/op_mod-ConstVar.js

    r221832 r221935  
    1 //@ if $buildType == "release" then runFTLNoCJIT("--timeoutMultiplier=1.5") else skip end
     1//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
    22
    33// If all goes well, this test module will terminate silently. If not, it will print

  • trunk/JSTests/stress/op_mod-VarConst.js

    r221832 r221935  
    1 //@ if $buildType == "release" then runFTLNoCJIT("--timeoutMultiplier=1.5") else skip end
     1//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
    22
    33// If all goes well, this test module will terminate silently. If not, it will print

  • trunk/JSTests/stress/op_mod-VarVar.js

    r221832 r221935  
    1 //@ if $buildType == "release" then runFTLNoCJIT("--timeoutMultiplier=1.5") else skip end
     1//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
    22
    33// If all goes well, this test module will terminate silently. If not, it will print
Note: See TracChangeset for help on using the changeset viewer.