Changeset 222211 in webkit

Timestamp:

Sep 19, 2017, 10:41:42 AM (8 years ago)

Author:

achristensen@apple.com

Message:

Make _WKProcessPoolConfiguration.allowsCellularAccess actually work on iOS
​https://bugs.webkit.org/show_bug.cgi?id=177124

Reviewed by Andy Estes.

The boolean added in r213747 was getting lost in two places:

1. The API::ProcessPoolConfiguration gets copied before it's used, so we need to set the bool on the copy.
2. The bool was not getting copied from that ProcessPoolConfiguration to the NetworkProcessCreationParameters

to be sent to the NetworkProcess to be given to the NSURLSessionConfiguration in NetworkSessionCocoa.mm.

These two problems were fixed and verified manually with a customized iOS app on my phone.
Unfortunately, this cannot be tested well with our current test infrastructure.

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/APIProcessPoolConfiguration.cpp (modified) (1 diff)
• UIProcess/API/APIProcessPoolConfiguration.h (modified) (2 diffs)
• UIProcess/WebProcessPool.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-09-19  Alex Christensen  <achristensen@webkit.org>
+
+        Make _WKProcessPoolConfiguration.allowsCellularAccess actually work on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=177124
+
+        Reviewed by Andy Estes.
+
+        The boolean added in r213747 was getting lost in two places:
+        1. The API::ProcessPoolConfiguration gets copied before it's used, so we need to set the bool on the copy.
+        2. The bool was not getting copied from that ProcessPoolConfiguration to the NetworkProcessCreationParameters
+        to be sent to the NetworkProcess to be given to the NSURLSessionConfiguration in NetworkSessionCocoa.mm.
+
+        These two problems were fixed and verified manually with a customized iOS app on my phone.
+        Unfortunately, this cannot be tested well with our current test infrastructure.
+
+        * UIProcess/API/APIProcessPoolConfiguration.cpp:
+        (API::ProcessPoolConfiguration::copy):
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::ensureNetworkProcess):
+
 2017-09-18  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp

@@ -127 +127 @@
     copy->m_ignoreSynchronousMessagingTimeoutsForTesting = this->m_ignoreSynchronousMessagingTimeoutsForTesting;
     copy->m_overrideLanguages = this->m_overrideLanguages;
+    copy->m_allowsCellularAccess = this->m_allowsCellularAccess;
     copy->m_sourceApplicationBundleIdentifier = this->m_sourceApplicationBundleIdentifier;
     copy->m_sourceApplicationSecondaryIdentifier = this->m_sourceApplicationSecondaryIdentifier;

trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h

@@ -24 +24 @@
  */
 
-#ifndef APIContextConfiguration_h
-#define APIContextConfiguration_h
+#pragma once
 
 #include "APIObject.h"
@@ -182 +181 @@
 
 } // namespace API
-
-#endif // APIContextConfiguration_h

trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

@@ -458 +458 @@
     if (!parentBundleDirectory.isEmpty())
         SandboxExtension::createHandle(parentBundleDirectory, SandboxExtension::Type::ReadOnly, parameters.parentBundleDirectoryExtensionHandle);
+
+    parameters.allowsCellularAccess = m_configuration->allowsCellularAccess();
 #endif