Changeset 222325 in webkit

Timestamp:

Sep 21, 2017, 10:12:24 AM (8 years ago)

Author:

achristensen@apple.com

Message:

Fix ASAN build after r222306
​https://bugs.webkit.org/show_bug.cgi?id=177255

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setCustomHeaderFields):

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::setCustomHeaderFields): Deleted.
Moving a Vector of a type requires more than just a forward declaration of the type, but only in ASAN builds. Weird.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/DocumentLoader.cpp (modified) (1 diff)
• loader/DocumentLoader.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-09-21  Alex Christensen  <achristensen@webkit.org>
+
+        Fix ASAN build after r222306
+        https://bugs.webkit.org/show_bug.cgi?id=177255
+
+        * loader/DocumentLoader.cpp:
+        (WebCore::DocumentLoader::setCustomHeaderFields):
+        * loader/DocumentLoader.h:
+        (WebCore::DocumentLoader::setCustomHeaderFields): Deleted.
+        Moving a Vector of a type requires more than just a forward declaration of the type, but only in ASAN builds.  Weird.
+
 2017-09-21  Zhifei FANG  <facetothefate@gmail.com>
 

trunk/Source/WebCore/loader/DocumentLoader.cpp

@@ -1037 +1037 @@
 }
 
+void DocumentLoader::setCustomHeaderFields(Vector<HTTPHeaderField>&& fields)
+{
+    m_customHeaderFields = WTFMove(fields);
+}
+
 bool DocumentLoader::isLoadingInAPISense() const
 {

trunk/Source/WebCore/loader/DocumentLoader.h

@@ -297 +297 @@
     const Vector<LinkIcon>& linkIcons() const { return m_linkIcons; }
 
-    void setCustomHeaderFields(Vector<HTTPHeaderField>&& fields) { m_customHeaderFields = WTFMove(fields); }
+    void setCustomHeaderFields(Vector<HTTPHeaderField>&& fields);
     
 protected: