Changeset 222638 in webkit


Ignore:
Timestamp:
Sep 28, 2017, 4:32:53 PM (8 years ago)
Author:
mark.lam@apple.com
Message:

test262: Unexpected passes after r222617 and r222618.
​https://bugs.webkit.org/show_bug.cgi?id=177622
<rdar://problem/34725960>

Reviewed by Saam Barati.

JSTests:

Update test262.yaml for tests that are now passing.

  • test262.yaml:

Source/JavaScriptCore:

Now that these tests are marked as "normal", we will run them and discover a few
missing exception checks. This patch also adds those missing exception checks.

  • runtime/DatePrototype.cpp:

(JSC::fillStructuresUsingDateArgs):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/JSTests/ChangeLog

    r222601 r222638  
     12017-09-28  Mark Lam  <mark.lam@apple.com>
     2
     3        test262: Unexpected passes after r222617 and r222618.
     4        https://bugs.webkit.org/show_bug.cgi?id=177622
     5        <rdar://problem/34725960>
     6
     7        Reviewed by Saam Barati.
     8
     9        Update test262.yaml for tests that are now passing.
     10
     11        * test262.yaml:
     12
    1132017-09-27  Michael Saboff  <msaboff@apple.com>
    214

  • trunk/JSTests/test262.yaml

    r222428 r222638  
    34553455  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:strict]
    34563456- path: test262/test/built-ins/Array/prototype/copyWithin/return-abrupt-from-delete-proxy-target.js
    3457   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
     3457  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    34583458- path: test262/test/built-ins/Array/prototype/copyWithin/return-abrupt-from-delete-proxy-target.js
    3459   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
     3459  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    34603460- path: test262/test/built-ins/Array/prototype/copyWithin/return-abrupt-from-delete-target.js
    34613461  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    … …  
    1703717037  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1703817038- path: test262/test/built-ins/Date/prototype/setDate/arg-to-number-err.js
    17039   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
     17039  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    1704017040- path: test262/test/built-ins/Date/prototype/setDate/arg-to-number-err.js
    17041   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
     17041  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1704217042- path: test262/test/built-ins/Date/prototype/setDate/arg-to-number.js
    1704317043  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    … …  
    1710117101  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1710217102- path: test262/test/built-ins/Date/prototype/setFullYear/arg-date-to-number-err.js
    17103   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
     17103  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    1710417104- path: test262/test/built-ins/Date/prototype/setFullYear/arg-date-to-number-err.js
    17105   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
     17105  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1710617106- path: test262/test/built-ins/Date/prototype/setFullYear/arg-date-to-number.js
    1710717107  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    … …  
    1710917109  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1711017110- path: test262/test/built-ins/Date/prototype/setFullYear/arg-month-to-number-err.js
    17111   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
     17111  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    1711217112- path: test262/test/built-ins/Date/prototype/setFullYear/arg-month-to-number-err.js
    17113   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
     17113  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1711417114- path: test262/test/built-ins/Date/prototype/setFullYear/arg-month-to-number.js
    1711517115  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    … …  
    1711717117  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1711817118- path: test262/test/built-ins/Date/prototype/setFullYear/arg-year-to-number-err.js
    17119   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
     17119  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    1712017120- path: test262/test/built-ins/Date/prototype/setFullYear/arg-year-to-number-err.js
    17121   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
     17121  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1712217122- path: test262/test/built-ins/Date/prototype/setFullYear/arg-year-to-number.js
    1712317123  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    … …  
    1741717417  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1741817418- path: test262/test/built-ins/Date/prototype/setMonth/arg-date-to-number-err.js
    17419   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
     17419  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    1742017420- path: test262/test/built-ins/Date/prototype/setMonth/arg-date-to-number-err.js
    17421   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
     17421  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1742217422- path: test262/test/built-ins/Date/prototype/setMonth/arg-date-to-number.js
    1742317423  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    … …  
    1742517425  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1742617426- path: test262/test/built-ins/Date/prototype/setMonth/arg-month-to-number-err.js
    17427   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
     17427  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
    1742817428- path: test262/test/built-ins/Date/prototype/setMonth/arg-month-to-number-err.js
    17429   cmd: runTest262 :fail, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
     17429  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
    1743017430- path: test262/test/built-ins/Date/prototype/setMonth/arg-month-to-number.js
    1743117431  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []

  • trunk/Source/JavaScriptCore/ChangeLog

    r222625 r222638  
     12017-09-28  Mark Lam  <mark.lam@apple.com>
     2
     3        test262: Unexpected passes after r222617 and r222618.
     4        https://bugs.webkit.org/show_bug.cgi?id=177622
     5        <rdar://problem/34725960>
     6
     7        Reviewed by Saam Barati.
     8
     9        Now that these tests are marked as "normal", we will run them and discover a few
     10        missing exception checks.  This patch also adds those missing exception checks.
     11
     12        * runtime/DatePrototype.cpp:
     13        (JSC::fillStructuresUsingDateArgs):
     14
    1152017-09-28  Filip Pizlo  <fpizlo@apple.com>
    216

  • trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp

    r222617 r222638  
    405405static bool fillStructuresUsingDateArgs(ExecState *exec, int maxArgs, double *ms, GregorianDateTime *t)
    406406{
     407    VM& vm = exec->vm();
     408    auto scope = DECLARE_THROW_SCOPE(vm);
     409
    407410    int idx = 0;
    408411    bool ok = true;
    … …  
    416419    if (maxArgs >= 3 && idx < numArgs) {
    417420        double years = exec->uncheckedArgument(idx++).toIntegerPreserveNaN(exec);
     421        RETURN_IF_EXCEPTION(scope, false);
    418422        ok = std::isfinite(years);
    419423        t->setYear(toInt32(years));
    … …  
    422426    if (maxArgs >= 2 && idx < numArgs && ok) {
    423427        double months = exec->uncheckedArgument(idx++).toIntegerPreserveNaN(exec);
     428        RETURN_IF_EXCEPTION(scope, false);
    424429        ok = std::isfinite(months);
    425430        t->setMonth(toInt32(months));
    … …  
    428433    if (idx < numArgs && ok) {
    429434        double days = exec->uncheckedArgument(idx++).toIntegerPreserveNaN(exec);
     435        RETURN_IF_EXCEPTION(scope, false);
    430436        ok = std::isfinite(days);
    431437        t->setMonthDay(0);
Note: See TracChangeset for help on using the changeset viewer.