Changeset 223555 in webkit


Ignore:
Timestamp:
Oct 17, 2017 10:37:10 AM (6 years ago)
Author:
achristensen@apple.com
Message:

Layout Test http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=150095

Reviewed by Tim Horton.

  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt:
  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html:
  • platform/mac-wk2/TestExpectations:

We were mixing jsTestIsAsync with testRunner.notifyDone which caused some flakiness.
Calling finishJSTest on the next runloop iteration causes it to no longer be flaky.

Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r223554 r223555  
     12017-10-17  Alex Christensen  <achristensen@webkit.org>
     2
     3        Layout Test http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=150095
     5
     6        Reviewed by Tim Horton.
     7
     8        * http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt:
     9        * http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html:
     10        * platform/mac-wk2/TestExpectations:
     11        We were mixing jsTestIsAsync with testRunner.notifyDone which caused some flakiness.
     12        Calling finishJSTest on the next runloop iteration causes it to no longer be flaky.
     13
    1142017-10-17  Alex Christensen  <achristensen@webkit.org>
    215
  • trunk/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt

    r219663 r223555  
    1515Testing overrideMimeType when readyState = 4
    1616PASS req.overrideMimeType("text/plain") threw exception InvalidStateError: The object is in an invalid state..
     17PASS successfullyParsed is true
    1718
     19TEST COMPLETE
     20
  • trunk/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html

    r173925 r223555  
    2626    }
    2727
    28     if (req.readyState == req.DONE) {
    29         if (window.testRunner)
    30             testRunner.notifyDone();
    31     }     
     28    if (req.readyState == req.DONE)
     29        setTimeout(finishJSTest, 0);
    3230}
    3331
  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r223554 r223555  
    333333webkit.org/b/149087 [ Debug ] http/tests/cache/disk-cache/disk-cache-vary-no-body.html [ Pass Failure Timeout ]
    334334
    335 
    336 
    337 webkit.org/b/150095 http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html [ Pass Timeout ]
    338 
    339335webkit.org/b/150241 webarchive/loading/object.html [ Pass Crash ]
    340336
Note: See TracChangeset for help on using the changeset viewer.