Changeset 223613 in webkit


Ignore:
Timestamp:
Oct 18, 2017 10:16:41 AM (6 years ago)
Author:
achristensen@apple.com
Message:

http/tests/loading/basic-auth-resend-wrong-credentials.html is still a flaky failure after proposed fix.
​https://bugs.webkit.org/show_bug.cgi?id=178467

Reviewed by Andy Estes.

  • http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
  • http/tests/loading/basic-auth-resend-wrong-credentials.html:
  • platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:

Use setTimeout to make the loading order deterministic.
The important part of this test is that the passwords shown in the delegate callbacks are correct,
and this doesn't change that.

Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r223609 r223613  
     12017-10-18  Alex Christensen  <achristensen@webkit.org>
     2
     3        http/tests/loading/basic-auth-resend-wrong-credentials.html is still a flaky failure after proposed fix.
     4        https://bugs.webkit.org/show_bug.cgi?id=178467
     5
     6        Reviewed by Andy Estes.
     7
     8        * http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
     9        * http/tests/loading/basic-auth-resend-wrong-credentials.html:
     10        * platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
     11        Use setTimeout to make the loading order deterministic.
     12        The important part of this test is that the passwords shown in the delegate callbacks are correct,
     13        and this doesn't change that.
     14
    1152017-10-18  Ms2ger  <Ms2ger@igalia.com>
    216

  • trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt

    r223554 r223613  
    22main frame - didCommitLoadForFrame
    33main frame - didFinishDocumentLoadForFrame
     4main frame - didHandleOnloadEventsForFrame
     5main frame - didFinishLoadForFrame
    46frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
    5 main frame - didHandleOnloadEventsForFrame
    67http://127.0.0.1:8000/loading/resources/test2/protected-resource.php - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
    78frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
    … …  
    1314frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
    1415frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
    15 frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
    16 frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
    17 main frame - didFinishLoadForFrame
    1816This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
    1917

  • trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html

    r223554 r223613  
    3737</script>
    3838</head>
    39 <body onload="makeIFrame()">
     39<body onload="setTimeout(makeIFrame, 0)">
    4040This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.<br>
    4141</body>

  • trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt

    r223554 r223613  
    22main frame - didCommitLoadForFrame
    33main frame - didFinishDocumentLoadForFrame
     4main frame - didHandleOnloadEventsForFrame
     5main frame - didFinishLoadForFrame
    46frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
    5 main frame - didHandleOnloadEventsForFrame
    67127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
    78frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
    … …  
    1314frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
    1415frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
    15 frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
    16 frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
    17 main frame - didFinishLoadForFrame
    1816This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
    1917
Note: See TracChangeset for help on using the changeset viewer.