Changeset 223982 in webkit


Ignore:
Timestamp:
Oct 25, 2017 2:19:19 PM (6 years ago)
Author:
achristensen@apple.com
Message:

LayoutTest http/tests/loading/basic-credentials-sent-automatically.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=159427

Reviewed by Youenn Fablet.

Use setTimeout to make load delegate callback printing more deterministic.
The important part is that the credentials are printed, and they still are.

  • http/tests/loading/basic-credentials-sent-automatically-expected.txt:
  • http/tests/loading/basic-credentials-sent-automatically.html:
  • platform/mac/TestExpectations:
  • platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r223981 r223982  
     12017-10-25  Alex Christensen  <achristensen@webkit.org>
     2
     3        LayoutTest http/tests/loading/basic-credentials-sent-automatically.html is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=159427
     5
     6        Reviewed by Youenn Fablet.
     7       
     8        Use setTimeout to make load delegate callback printing more deterministic.
     9        The important part is that the credentials are printed, and they still are.
     10
     11        * http/tests/loading/basic-credentials-sent-automatically-expected.txt:
     12        * http/tests/loading/basic-credentials-sent-automatically.html:
     13        * platform/mac/TestExpectations:
     14        * platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
     15
    1162017-10-25  Youenn Fablet  <youenn@apple.com>
    217
  • trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt

    r223445 r223982  
    22main frame - didCommitLoadForFrame
    33main frame - didFinishDocumentLoadForFrame
     4main frame - didHandleOnloadEventsForFrame
     5main frame - didFinishLoadForFrame
    46frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
    5 main frame - didHandleOnloadEventsForFrame
    67http://127.0.0.1:8000/loading/resources/subresources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with first:first-pw
    78frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
    89frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
    9 frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
    1010frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
    1111frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
     12frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
    1213http://127.0.0.1:8000/loading/resources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with second:second-pw
    1314frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
    1415frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
    15 frame "<!--framePath //<!--frame2-->-->" - didStartProvisionalLoadForFrame
    1616frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
    1717frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
     18frame "<!--framePath //<!--frame2-->-->" - didStartProvisionalLoadForFrame
    1819frame "<!--framePath //<!--frame2-->-->" - didCommitLoadForFrame
    1920frame "<!--framePath //<!--frame2-->-->" - didFinishDocumentLoadForFrame
    20 frame "<!--framePath //<!--frame3-->-->" - didStartProvisionalLoadForFrame
    2121frame "<!--framePath //<!--frame2-->-->" - didHandleOnloadEventsForFrame
    2222frame "<!--framePath //<!--frame2-->-->" - didFinishLoadForFrame
     23frame "<!--framePath //<!--frame3-->-->" - didStartProvisionalLoadForFrame
    2324frame "<!--framePath //<!--frame3-->-->" - didCommitLoadForFrame
    2425frame "<!--framePath //<!--frame3-->-->" - didFinishDocumentLoadForFrame
    2526frame "<!--framePath //<!--frame3-->-->" - didHandleOnloadEventsForFrame
    2627frame "<!--framePath //<!--frame3-->-->" - didFinishLoadForFrame
    27 main frame - didFinishLoadForFrame
    2828This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.
    2929The first frame's path is /loading/resources/subresources/protected-resource.php, and we should get a challenge for it.
  • trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html

    r223445 r223982  
    1919    var frame = document.createElement("iframe");
    2020    frame.setAttribute("src", "http://127.0.0.1:8000/loading/resources/protected-resource.php");
    21     frame.setAttribute("onload", "secondFrameLoaded()");
     21    frame.setAttribute("onload", "setTimeout(secondFrameLoaded, 0)");
    2222    document.body.appendChild(frame);
    2323}
     
    3131    var frame = document.createElement("iframe");
    3232    frame.setAttribute("src", "http://127.0.0.1:8000/loading/resources/protected-resource.php");
    33     frame.setAttribute("onload", "thirdFrameLoaded()");
     33    frame.setAttribute("onload", "setTimeout(thirdFrameLoaded, 0)");
    3434    document.body.appendChild(frame);
    3535}
     
    4343    var frame = document.createElement("iframe");
    4444    frame.setAttribute("src", "http://127.0.0.1:8000/loading/resources/othersubresources/protected-resource.php");
    45     frame.setAttribute("onload", "fourthFrameLoaded()");
     45    frame.setAttribute("onload", "setTimeout(fourthFrameLoaded, 0)");
    4646    document.body.appendChild(frame);
    4747}
     
    5555function makeIFrame() {
    5656    var iframe = document.createElement("iframe");
    57     iframe.onload=firstFrameLoaded;
     57    iframe.setAttribute("onload", "setTimeout(firstFrameLoaded, 0)");
    5858    iframe.src="resources/subresources/protected-resource.php";
    5959    document.body.appendChild(iframe);
     
    6262</script>
    6363</head>
    64 <body onload="makeIFrame()">
     64<body onload="setTimeout(makeIFrame, 0)">
    6565This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.<br>
    6666The first frame's path is /loading/resources/subresources/protected-resource.php, and we should get a challenge for it.<br>
  • trunk/LayoutTests/platform/mac/TestExpectations

    r223967 r223982  
    17891789
    17901790webkit.org/b/178465 [ Debug ] fast/html/marquee-reparent-check.html [ Skip ]
    1791 
    1792 webkit.org/b/159427 http/tests/loading/basic-credentials-sent-automatically.html [ Pass Failure ]
  • trunk/LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt

    r223445 r223982  
    22main frame - didCommitLoadForFrame
    33main frame - didFinishDocumentLoadForFrame
     4main frame - didHandleOnloadEventsForFrame
     5main frame - didFinishLoadForFrame
    46frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
    5 main frame - didHandleOnloadEventsForFrame
    67127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with first:first-pw
    78frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
    89frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
    9 frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
    1010frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
    1111frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
     12frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
    1213127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with second:second-pw
    1314frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
    1415frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
    15 frame "<!--framePath //<!--frame2-->-->" - didStartProvisionalLoadForFrame
    1616frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
    1717frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
     18frame "<!--framePath //<!--frame2-->-->" - didStartProvisionalLoadForFrame
    1819frame "<!--framePath //<!--frame2-->-->" - didCommitLoadForFrame
    1920frame "<!--framePath //<!--frame2-->-->" - didFinishDocumentLoadForFrame
    20 frame "<!--framePath //<!--frame3-->-->" - didStartProvisionalLoadForFrame
    2121frame "<!--framePath //<!--frame2-->-->" - didHandleOnloadEventsForFrame
    2222frame "<!--framePath //<!--frame2-->-->" - didFinishLoadForFrame
     23frame "<!--framePath //<!--frame3-->-->" - didStartProvisionalLoadForFrame
    2324frame "<!--framePath //<!--frame3-->-->" - didCommitLoadForFrame
    2425frame "<!--framePath //<!--frame3-->-->" - didFinishDocumentLoadForFrame
    2526frame "<!--framePath //<!--frame3-->-->" - didHandleOnloadEventsForFrame
    2627frame "<!--framePath //<!--frame3-->-->" - didFinishLoadForFrame
    27 main frame - didFinishLoadForFrame
    2828This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.
    2929The first frame's path is /loading/resources/subresources/protected-resource.php, and we should get a challenge for it.
Note: See TracChangeset for help on using the changeset viewer.