Changeset 224432 in webkit


Ignore:
Timestamp:
Nov 3, 2017, 2:30:08 PM (8 years ago)
Author:
achristensen@apple.com
Message:

LayoutTest http/tests/loading/basic-auth-resend-wrong-credentials.html is flaky on WK2
​https://bugs.webkit.org/show_bug.cgi?id=159884

Reviewed by Darin Adler.

  • http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
  • http/tests/loading/basic-auth-resend-wrong-credentials.html:
  • platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r224430 r224432  
     12017-11-03  Alex Christensen  <achristensen@webkit.org>
     2
     3        LayoutTest http/tests/loading/basic-auth-resend-wrong-credentials.html is flaky on WK2
     4        https://bugs.webkit.org/show_bug.cgi?id=159884
     5
     6        Reviewed by Darin Adler.
     7
     8        * http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
     9        * http/tests/loading/basic-auth-resend-wrong-credentials.html:
     10        * platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
     11
    1122017-11-03  Ryan Haddad  <ryanhaddad@apple.com>
    213

  • trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt

    r223613 r224432  
    88frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
    99frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
    10 frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
    1110frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
    1211frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
     12frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
    1313http://127.0.0.1:8000/loading/resources/test2/basic-auth-testing.php?username=correctusername&password=correctpassword - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
    1414frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
    1515frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
     16frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
     17frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
    1618This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
    1719

  • trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html

    r223613 r224432  
    1313
    1414function firstFrameLoaded() {
    15     if (window.testRunner) {
    16         testRunner.setAuthenticationUsername("correctusername");
    17         testRunner.setAuthenticationPassword("correctpassword");
    18     }
    19     var frame = document.createElement("iframe");
    20     frame.setAttribute("src", "http://127.0.0.1:8000/loading/resources/test2/basic-auth-testing.php?username=correctusername&password=correctpassword");
    21     frame.setAttribute("onload", "secondFrameLoaded()");
    22     document.body.appendChild(frame);
     15    setTimeout(()=>{
     16        if (window.testRunner) {
     17            testRunner.setAuthenticationUsername("correctusername");
     18            testRunner.setAuthenticationPassword("correctpassword");
     19        }
     20        var frame = document.createElement("iframe");
     21        frame.setAttribute("src", "http://127.0.0.1:8000/loading/resources/test2/basic-auth-testing.php?username=correctusername&password=correctpassword");
     22        frame.setAttribute("onload", "secondFrameLoaded()");
     23        document.body.appendChild(frame);
     24    }, 0);
    2325}
    2426

  • trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt

    r223613 r224432  
    88frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
    99frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
    10 frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
    1110frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
    1211frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
     12frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
    1313127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
    1414frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
    1515frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
     16frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
     17frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
    1618This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
    1719
Note: See TracChangeset for help on using the changeset viewer.