Changeset 224827 in webkit


Ignore:
Timestamp:
Nov 14, 2017 11:50:30 AM (6 years ago)
Author:
achristensen@apple.com
Message:

Remove assertions added in r224791
https://bugs.webkit.org/show_bug.cgi?id=178751#c10

  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
I had added assertions that sandbox extension handle consumption succeeds.
In the API test IndexedDB.StructuredCloneBackwardCompatibility we get a sandbox extension handle
to give access to a directory that does not exist and consumption fails. We want it to fail,
so my optimistic addition of a success assertion was incorrect. The test passes without it
and behaves like it used to.

Location:
trunk/Source/WebKit
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r224825 r224827  
     12017-11-14  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove assertions added in r224791
     4        https://bugs.webkit.org/show_bug.cgi?id=178751#c10
     5
     6        * NetworkProcess/mac/RemoteNetworkingContext.mm:
     7        (WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
     8        * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
     9        (WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
     10        I had added assertions that sandbox extension handle consumption succeeds.
     11        In the API test IndexedDB.StructuredCloneBackwardCompatibility we get a sandbox extension handle
     12        to give access to a directory that does not exist and consumption fails.  We want it to fail,
     13        so my optimistic addition of a success assertion was incorrect.  The test passes without it
     14        and behaves like it used to.
     15
    1162017-11-14  Tim Horton  <timothy_horton@apple.com>
    217
  • trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm

    r224791 r224827  
    9494        base = SessionTracker::getIdentifierBase();
    9595
    96     if (!sessionID.isEphemeral()) {
    97         bool result = SandboxExtension::consumePermanently(parameters.cookieStoragePathExtensionHandle);
    98         ASSERT_UNUSED(result, result);
    99     }
     96    if (!sessionID.isEphemeral())
     97        SandboxExtension::consumePermanently(parameters.cookieStoragePathExtensionHandle);
    10098
    10199    RetainPtr<CFHTTPCookieStorageRef> uiProcessCookieStorage;
  • trunk/Source/WebKit/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm

    r224791 r224827  
    5959        base = SessionTracker::getIdentifierBase();
    6060
    61     if (!sessionID.isEphemeral()) {
    62         bool result = SandboxExtension::consumePermanently(parameters.cookieStoragePathExtensionHandle);
    63         ASSERT_UNUSED(result, result);
    64     }
     61    if (!sessionID.isEphemeral())
     62        SandboxExtension::consumePermanently(parameters.cookieStoragePathExtensionHandle);
    6563
    6664    RetainPtr<CFHTTPCookieStorageRef> uiProcessCookieStorage;
Note: See TracChangeset for help on using the changeset viewer.