Changeset 224850 in webkit

Timestamp:

Nov 14, 2017 2:59:42 PM (6 years ago)

Author:

achristensen@apple.com

Message:

Log moveFile failure errors
​https://bugs.webkit.org/show_bug.cgi?id=179695

Reviewed by Brady Eidson.

Content extension tests are flaky. In r224790 I added logs to find out why, and they indicate that moveFile is failing.
To further understand why, I'm adding logs to see what's happening sometimes on the bots.

• platform/cocoa/FileSystemCocoa.mm:

(WebCore::FileSystem::moveFile):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/cocoa/FileSystemCocoa.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-11-14  Alex Christensen  <achristensen@webkit.org>
+
+        Log moveFile failure errors
+        https://bugs.webkit.org/show_bug.cgi?id=179695
+
+        Reviewed by Brady Eidson.
+
+        Content extension tests are flaky. In r224790 I added logs to find out why, and they indicate that moveFile is failing.
+        To further understand why, I'm adding logs to see what's happening sometimes on the bots.
+
+        * platform/cocoa/FileSystemCocoa.mm:
+        (WebCore::FileSystem::moveFile):
+
 2017-11-14  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/platform/cocoa/FileSystemCocoa.mm

@@ -90 +90 @@
     [manager setDelegate:delegate.get()];
     
-    return [manager moveItemAtURL:[NSURL fileURLWithPath:oldPath] toURL:[NSURL fileURLWithPath:newPath] error:nil];
+    NSError *error = nil;
+    bool success = [manager moveItemAtURL:[NSURL fileURLWithPath:oldPath] toURL:[NSURL fileURLWithPath:newPath] error:&error];
+    if (!success)
+        NSLog(@"Error in moveFile: %@", error);
+    return success;
 }