Changeset 226897 in webkit


Ignore:
Timestamp:
Jan 12, 2018, 10:26:53 AM (7 years ago)
Author:
achristensen@apple.com
Message:

REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
​https://bugs.webkit.org/show_bug.cgi?id=181595

This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
I change the < and > to $ to make this test pass and continue to test what it used to.

  • TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
  • TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:

(-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r226879 r226897  
     12018-01-12  Alex Christensen  <achristensen@webkit.org>
     2
     3        REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=181595
     5
     6        This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
     7        It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
     8        I change the < and > to $ to make this test pass and continue to test what it used to.
     9
     10        * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
     11        * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
     12        (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
     13
    1142018-01-11  Keith Miller  <keith_miller@apple.com>
    215

  • trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html

    r198956 r226897  
    44</head>
    55<body>
    6     <a id="href" href="https://www.example.com<>/">https://www.example.com&lt;&gt;/</a>
     6    <a id="href" href="https://www.example.com$/">https://www.example.com$/</a>
    77    <script>
    88        var element = document.getElementById("href");

  • trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm

    r221505 r226897  
    5151    EXPECT_EQ(error.code, WebKitErrorCannotShowURL);
    5252
    53     static char literal[] = "https://www.example.com<>/";
     53    static char literal[] = "https://www.example.com$/";
    5454    NSURL *failedURL = WebCore::URLWithData([NSData dataWithBytes:literal length:strlen(literal)], nil);
    5555    EXPECT_TRUE([error.userInfo[@"NSErrorFailingURLKey"] isEqual:failedURL]);
Note: See TracChangeset for help on using the changeset viewer.