Changeset 227547 in webkit


Ignore:
Timestamp:
Jan 24, 2018 12:48:32 PM (6 years ago)
Author:
ap@apple.com
Message:

REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=181400
<rdar://problem/36358768>

Reviewed by Joseph Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):

Always disable poisoning when running with --leaks, as this should work locally,
not just on bots.

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

    r227342 r227547  
    130130                    { "name": "Apple High Sierra (Leaks)", "type": "TestWebKit1Leaks", "builddir": "highsierra-leaks",
    131131                      "platform": "mac-highsierra", "configuration": "release", "architectures": ["x86_64"],
    132                       "additionalArguments": ["--no-retry-failures", "--no-sample-on-timeout", "--JSC_usePoisoning=0"],
     132                      "additionalArguments": ["--no-retry-failures", "--no-sample-on-timeout"],
    133133                      "slavenames": ["bot121"]
    134134                    },

  • trunk/Tools/ChangeLog

    r227533 r227547  
     12018-01-24  Alexey Proskuryakov  <ap@apple.com>
     2
     3        REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
     4        https://bugs.webkit.org/show_bug.cgi?id=181400
     5        <rdar://problem/36358768>
     6
     7        Reviewed by Joseph Pecoraro.
     8
     9        * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
     10
     11        * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
     12        Always disable poisoning when running with --leaks, as this should work locally,
     13        not just on bots.
     14
    1152018-01-24  Daniel Bates  <dabates@apple.com>
    216

  • trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

    r226715 r227547  
    430430        options.webkit_test_runner = True
    431431
     432    if options.leaks:
     433        options.additional_env_var.append("JSC_usePoisoning=0")
     434        options.additional_env_var.append("__XPC_JSC_usePoisoning=0")
    432435
    433436def run(port, options, args, logging_stream):
Note: See TracChangeset for help on using the changeset viewer.