Changeset 230567 in webkit

Timestamp:

Apr 12, 2018 6:41:00 AM (6 years ago)

Author:

Kocsen Chung

Message:

Cherry-pick r229872. rdar://problem/39349363

Use the same SWServer for all ephemeral sessions
​https://bugs.webkit.org/show_bug.cgi?id=183921
<rdar://problem/36873075>

Reviewed by Youenn Fablet.

Use the same SWServer for all ephemeral sessions. SWServers never go away and we create
one per sessionID. When browsing doing private browsing in Safari (and other fetching
favorite icons), the sessionID is ephemeral and keeps changing. This means that we kept
constructing new SWServers that would never go away. Each SWServer has a thread so we
would eventually hit the thread limit for the storage process.

• StorageProcess/StorageProcess.cpp: (WebKit::StorageProcess::swServerForSession):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@229872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-605-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• StorageProcess/StorageProcess.cpp (modified) (1 diff)

branches/safari-605-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2018-04-11  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Cherry-pick r229872. rdar://problem/39349363
+
+    Use the same SWServer for all ephemeral sessions
+    https://bugs.webkit.org/show_bug.cgi?id=183921
+    <rdar://problem/36873075>
+    
+    Reviewed by Youenn Fablet.
+    
+    Use the same SWServer for all ephemeral sessions. SWServers never go away and we create
+    one per sessionID. When browsing doing private browsing in Safari (and other fetching
+    favorite icons), the sessionID is ephemeral and keeps changing. This means that we kept
+    constructing new SWServers that would never go away. Each SWServer has a thread so we
+    would eventually hit the thread limit for the storage process.
+    
+    * StorageProcess/StorageProcess.cpp:
+    (WebKit::StorageProcess::swServerForSession):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2018-03-22  Chris Dumez  <cdumez@apple.com>
+
+            Use the same SWServer for all ephemeral sessions
+            https://bugs.webkit.org/show_bug.cgi?id=183921
+            <rdar://problem/36873075>
+
+            Reviewed by Youenn Fablet.
+
+            Use the same SWServer for all ephemeral sessions. SWServers never go away and we create
+            one per sessionID. When browsing doing private browsing in Safari (and other fetching
+            favorite icons), the sessionID is ephemeral and keeps changing. This means that we kept
+            constructing new SWServers that would never go away. Each SWServer has a thread so we
+            would eventually hit the thread limit for the storage process.
+
+            * StorageProcess/StorageProcess.cpp:
+            (WebKit::StorageProcess::swServerForSession):
+
 2018-04-10  Kocsen Chung  <kocsen_chung@apple.com>
 

branches/safari-605-branch/Source/WebKit/StorageProcess/StorageProcess.cpp

@@ -419 +419 @@
 {
     ASSERT(sessionID.isValid());
+
+    // Use the same SWServer for all ephemeral sessions.
+    if (sessionID.isEphemeral())
+        sessionID = PAL::SessionID::legacyPrivateSessionID();
+
     auto result = m_swServers.add(sessionID, nullptr);
     if (!result.isNewEntry) {