Changeset 232810 in webkit

Timestamp:

Jun 13, 2018 2:21:21 PM (6 years ago)

Author:

mark.lam@apple.com

Message:

Gardening: Layout Test js/error-should-not-strong-reference-global-object.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=186372

Not reviewed.

Speculative fix to green the bots plus improved the error message logging to get
more info if this fails again.

• js/error-should-not-strong-reference-global-object.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• js/error-should-not-strong-reference-global-object.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-06-13  Mark Lam  <mark.lam@apple.com>
+
+        Gardening: Layout Test js/error-should-not-strong-reference-global-object.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=186372
+
+        Not reviewed.
+
+        Speculative fix to green the bots plus improved the error message logging to get
+        more info if this fails again. 
+
+        * js/error-should-not-strong-reference-global-object.html:
+
 2018-06-13  Timothy Hatcher  <timothy@apple.com>
 

trunk/LayoutTests/js/error-should-not-strong-reference-global-object.html

@@ -41 +41 @@
     run();
 
-$vm.gc();
-// We shouldn't have more than 10% of the global objects we allocated.
-if ($vm.globalObjectCount() >= 51)
-    throw new Error("There are more global objects than there should be");
+setTimeout(() => {
+    $vm.gc();
+    // We shouldn't have more than 10% of the global objects we allocated.
+    var globalObjectCount = $vm.globalObjectCount();
+    if (globalObjectCount >= 51)
+        throw new Error("There are more global objects than there should be: actual count = " + globalObjectCount);
+}, 1);
 
 </script>