Changeset 234153 in webkit
- Timestamp:
- Jul 24, 2018 10:25:25 AM (6 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r234143 r234153 1 2018-07-24 Alex Christensen <achristensen@webkit.org> 2 3 Remove WebFramePolicyListenerProxy::invalidate 4 https://bugs.webkit.org/show_bug.cgi?id=187833 5 6 Reviewed by Dean Jackson. 7 8 When we're invalidating the listener, calling ignore instead will at worst cause 9 an ignored message to be sent. The load will be cancelled either way. 10 Removing the invalidate method gets it closer to being a lambda. 11 12 * UIProcess/WebFramePolicyListenerProxy.cpp: 13 (WebKit::WebFramePolicyListenerProxy::invalidate): Deleted. 14 * UIProcess/WebFramePolicyListenerProxy.h: 15 * UIProcess/WebFrameProxy.cpp: 16 (WebKit::WebFrameProxy::webProcessWillShutDown): 17 (WebKit::WebFrameProxy::setUpPolicyListenerProxy): 18 1 19 2018-07-24 Chris Dumez <cdumez@apple.com> 2 20 -
trunk/Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp
r234009 r234153 58 58 } 59 59 60 void WebFramePolicyListenerProxy::invalidate()61 {62 m_frame = nullptr;63 }64 65 60 bool WebFramePolicyListenerProxy::isMainFrame() const 66 61 { -
trunk/Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h
r234009 r234153 69 69 70 70 void setNavigation(Ref<API::Navigation>&&); 71 void invalidate();72 71 73 72 void changeWebsiteDataStore(WebsiteDataStore&); -
trunk/Source/WebKit/UIProcess/WebFrameProxy.cpp
r234009 r234153 66 66 67 67 if (m_activeListener) { 68 m_activeListener->i nvalidate();68 m_activeListener->ignore(); 69 69 m_activeListener = nullptr; 70 70 } … … 192 192 { 193 193 if (m_activeListener) 194 m_activeListener->i nvalidate();194 m_activeListener->ignore(); 195 195 m_activeListener = WebFramePolicyListenerProxy::create(this, listenerID, policyListenerType); 196 196 return *static_cast<WebFramePolicyListenerProxy*>(m_activeListener.get());
Note: See TracChangeset
for help on using the changeset viewer.