Changeset 235148 in webkit


Ignore:
Timestamp:
Aug 21, 2018 4:59:03 PM (6 years ago)
Author:
achristensen@apple.com
Message:

Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
​https://bugs.webkit.org/show_bug.cgi?id=188821

Reviewed by Simon Fraser.

Source/WebKit:

Add some more values to WKPageRenderingProgressEvents which were already supported by _WKRenderingProgressEvents and WKLayoutMilestones.

  • UIProcess/API/C/WKPageRenderingProgressEvents.h:
  • UIProcess/API/C/WKPageRenderingProgressEventsInternal.h:

(pageRenderingProgressEvents):

Tools:

  • TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:

(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r235146 r235148  
     12018-08-21  Alex Christensen  <achristensen@webkit.org>
     2
     3        Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
     4        https://bugs.webkit.org/show_bug.cgi?id=188821
     5
     6        Reviewed by Simon Fraser.
     7
     8        Add some more values to WKPageRenderingProgressEvents which were already supported by _WKRenderingProgressEvents and WKLayoutMilestones.
     9
     10        * UIProcess/API/C/WKPageRenderingProgressEvents.h:
     11        * UIProcess/API/C/WKPageRenderingProgressEventsInternal.h:
     12        (pageRenderingProgressEvents):
     13
    1142018-08-21  Alex Christensen  <achristensen@webkit.org>
    215

  • trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h

    r179588 r235148  
    3737    WKPageRenderingProgressEventFirstVisuallyNonEmptyLayout = 1 << 1,
    3838    WKPageRenderingProgressEventFirstPaintWithSignificantArea = 1 << 2,
    39     WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold = 1 << 3
     39    WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold = 1 << 3,
     40    WKPageRenderingProgressEventFirstLayoutAfterSuppressedIncrementalRendering = 1 << 4,
     41    WKPageRenderingProgressEventFirstPaintAfterSuppressedIncrementalRendering = 1 << 5,
    4042};
    4143typedef uint32_t WKPageRenderingProgressEvents;

  • trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEventsInternal.h

    r179589 r235148  
    4444        events |= WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold;
    4545   
     46    if (milestones & WebCore::DidFirstLayoutAfterSuppressedIncrementalRendering)
     47        events |= WKPageRenderingProgressEventFirstLayoutAfterSuppressedIncrementalRendering;
     48
     49    if (milestones & WebCore::DidFirstPaintAfterSuppressedIncrementalRendering)
     50        events |= WKPageRenderingProgressEventFirstPaintAfterSuppressedIncrementalRendering;
     51
    4652    return events;
    4753}

  • trunk/Tools/ChangeLog

    r235144 r235148  
     12018-08-21  Alex Christensen  <achristensen@webkit.org>
     2
     3        Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
     4        https://bugs.webkit.org/show_bug.cgi?id=188821
     5
     6        Reviewed by Simon Fraser.
     7
     8        * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
     9        (TestWebKitAPI::didLayout):
     10        (TestWebKitAPI::TEST):
     11
    1122018-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
    213

  • trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp

    r221505 r235148  
    4545static const unsigned expectedPageCount = 20;
    4646
    47 static void didLayout(WKPageRef page, WKLayoutMilestones milestones, WKTypeRef, const void* clientInfo)
     47static void didLayout(WKPageRef page, WKPageRenderingProgressEvents milestones, WKTypeRef, const void* clientInfo)
    4848{
    4949    if (milestones & kWKDidFirstLayoutAfterSuppressedIncrementalRendering) {
    … …  
    6565    PlatformWebView webView(context.get());
    6666
    67     WKPageLoaderClientV3 loaderClient;
     67    WKPageNavigationClientV3 loaderClient;
    6868    memset(&loaderClient, 0, sizeof(loaderClient));
    6969
    7070    loaderClient.base.version = 3;
    7171    loaderClient.base.clientInfo = &webView;
    72     loaderClient.didLayout = didLayout;
     72    loaderClient.renderingProgressDidChange = didLayout;
    7373
    74     WKPageSetPageLoaderClient(webView.page(), &loaderClient.base);
     74    WKPageSetPageNavigationClient(webView.page(), &loaderClient.base);
    7575
    7676    WKPageListenForLayoutMilestones(webView.page(), kWKDidFirstLayoutAfterSuppressedIncrementalRendering);
Note: See TracChangeset for help on using the changeset viewer.