Changeset 235405 in webkit

Timestamp:

Aug 27, 2018, 3:23:03 PM (8 years ago)

Author:

achristensen@apple.com

Message:

Fix API test after r235398
​https://bugs.webkit.org/show_bug.cgi?id=188997

• TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:

(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::willGoToBackForwardListItem): Deleted.
willGoToBackForwardListItem is unused and unsupported. Removing its check.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-08-27  Alex Christensen  <achristensen@webkit.org>
+
+        Fix API test after r235398
+        https://bugs.webkit.org/show_bug.cgi?id=188997
+
+        * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
+        (TestWebKitAPI::setPageLoaderClient):
+        (TestWebKitAPI::willGoToBackForwardListItem): Deleted.
+        willGoToBackForwardListItem is unused and unsupported.  Removing its check.
+
 2018-08-27  Daniel Bates  <dabates@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp

@@ -102 +102 @@
 }
 
-static void willGoToBackForwardListItem(WKPageRef, WKBackForwardListItemRef item, WKTypeRef userData, const void*)
-{
-    if (!itemURLLastComponentIsString(item, "simple.html"))
-        successfulSoFar = false;
-}
-
 static bool shouldKeepCurrentBackForwardListItemInList(WKPageRef page, WKBackForwardListItemRef item, const void*)
 {
@@ -124 +118 @@
     loaderClient.didFinishLoadForFrame = didFinishLoadForFrame;
     loaderClient.shouldKeepCurrentBackForwardListItemInList = shouldKeepCurrentBackForwardListItemInList;
-    loaderClient.willGoToBackForwardListItem = willGoToBackForwardListItem;
 
     WKPageSetPageLoaderClient(page, &loaderClient.base);