Changeset 236436 in webkit


Ignore:
Timestamp:
Sep 24, 2018, 4:04:56 PM (7 years ago)
Author:
achristensen@apple.com
Message:

Begin deprecating C API
​https://bugs.webkit.org/show_bug.cgi?id=189810

Reviewed by Andy Estes.

  • Shared/API/c/WKDeprecated.h: Added.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPagePolicyClient):
(-[WKBrowsingContextController setPolicyDelegate:]):

  • WebKit.xcodeproj/project.pbxproj:
Location:
trunk/Source/WebKit
Files:
1 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r236425 r236436  
     12018-09-24  Alex Christensen  <achristensen@webkit.org>
     2
     3        Begin deprecating C API
     4        https://bugs.webkit.org/show_bug.cgi?id=189810
     5
     6        Reviewed by Andy Estes.
     7
     8        * Shared/API/c/WKDeprecated.h: Added.
     9        * UIProcess/API/C/WKPage.h:
     10        * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
     11        (setUpPagePolicyClient):
     12        (-[WKBrowsingContextController setPolicyDelegate:]):
     13        * WebKit.xcodeproj/project.pbxproj:
     14
    1152018-09-24  Chris Dumez  <cdumez@apple.com>
    216

  • trunk/Source/WebKit/UIProcess/API/C/WKPage.h

    r216696 r236436  
    2828
    2929#include <WebKit/WKBase.h>
     30#include <WebKit/WKDeprecated.h>
    3031#include <WebKit/WKErrorRef.h>
    3132#include <WebKit/WKEvent.h>
    … …  
    225226
    226227// A client can implement either a navigation client or loader and policy clients, but never both.
    227 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client);
    228 WK_EXPORT void WKPageSetPagePolicyClient(WKPageRef page, const WKPagePolicyClientBase* client);
     228WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
     229WK_EXPORT void WKPageSetPagePolicyClient(WKPageRef page, const WKPagePolicyClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
    229230WK_EXPORT void WKPageSetPageNavigationClient(WKPageRef page, const WKPageNavigationClientBase* client);
    230231

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm

    r235828 r236436  
    515515    };
    516516
     517    ALLOW_DEPRECATED_DECLARATIONS_BEGIN
    517518    WKPageSetPagePolicyClient(toAPI(&page), &policyClient.base);
     519    ALLOW_DEPRECATED_DECLARATIONS_END
    518520}
    519521
    … …  
    544546    if (policyDelegate)
    545547        setUpPagePolicyClient(self, *_page);
    546     else
     548    else {
     549        ALLOW_DEPRECATED_DECLARATIONS_BEGIN
    547550        WKPageSetPagePolicyClient(toAPI(_page.get()), nullptr);
     551        ALLOW_DEPRECATED_DECLARATIONS_END
     552    }
    548553}
    549554

  • trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

    r236344 r236436  
    10511051                5C26958520043212005C439B /* WKOpenPanelParametersPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C26958420042F12005C439B /* WKOpenPanelParametersPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
    10521052                5C298DA01C3DF02100470AFE /* PendingDownload.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C298D9E1C3DEF2900470AFE /* PendingDownload.h */; };
     1053                5C359C0D2154739F009E7948 /* WKDeprecated.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C359C0C21547321009E7948 /* WKDeprecated.h */; settings = {ATTRIBUTES = (Private, ); }; };
    10531054                5C4B9D8B210A8CCF008F14D1 /* UndoOrRedo.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B9D8A210A8C46008F14D1 /* UndoOrRedo.h */; };
    10541055                5C62FDF91EFC271C00CE072E /* WKURLSchemeTaskPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C62FDF81EFC263C00CE072E /* WKURLSchemeTaskPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
    … …  
    34253426                5C26958420042F12005C439B /* WKOpenPanelParametersPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKOpenPanelParametersPrivate.h; sourceTree = "<group>"; };
    34263427                5C298D9E1C3DEF2900470AFE /* PendingDownload.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PendingDownload.h; sourceTree = "<group>"; };
     3428                5C359C0C21547321009E7948 /* WKDeprecated.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKDeprecated.h; sourceTree = "<group>"; };
    34273429                5C3AEA8E1FE1F1DF002318D3 /* WebsitePoliciesData.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebsitePoliciesData.cpp; sourceTree = "<group>"; };
    34283430                5C4B9D8A210A8C46008F14D1 /* UndoOrRedo.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = UndoOrRedo.h; sourceTree = "<group>"; };
    … …  
    82348236                                BC4075DC124FF0270068F20A /* WKData.h */,
    82358237                                377EAD4417E2C51A002D193D /* WKDeclarationSpecifiers.h */,
     8238                                5C359C0C21547321009E7948 /* WKDeprecated.h */,
    82368239                                1AFF48FE1833DE78009AB15A /* WKDeprecatedFunctions.cpp */,
    82378240                                8372DB2E1A677D4A00C697C5 /* WKDiagnosticLoggingResultType.h */,
    … …  
    95849587                                2E94FC1620351A6D00974BA0 /* WKDatePickerViewController.h in Headers */,
    95859588                                377EAD4517E2C51A002D193D /* WKDeclarationSpecifiers.h in Headers */,
     9589                                5C359C0D2154739F009E7948 /* WKDeprecated.h in Headers */,
    95869590                                8372DB2F1A677D4A00C697C5 /* WKDiagnosticLoggingResultType.h in Headers */,
    95879591                                BC4075FA124FF0270068F20A /* WKDictionary.h in Headers */,
Note: See TracChangeset for help on using the changeset viewer.