Changeset 236813 in webkit


Ignore:
Timestamp:
Oct 3, 2018, 3:02:44 PM (7 years ago)
Author:
mark.lam@apple.com
Message:

Suppress unreachable code warning for LLIntAssembly.h code.
​https://bugs.webkit.org/show_bug.cgi?id=190263
<rdar://problem/44986532>

Reviewed by Saam Barati.

This is needed because LLIntAssembly.h is template generated from LowLevelInterpreter
asm files, and may contain dead code which are harmless, but will trip up the warning.
We should suppress the warning so that it doesn't break builds.

  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r236805 r236813  
     12018-10-03  Mark Lam  <mark.lam@apple.com>
     2
     3        Suppress unreachable code warning for LLIntAssembly.h code.
     4        https://bugs.webkit.org/show_bug.cgi?id=190263
     5        <rdar://problem/44986532>
     6
     7        Reviewed by Saam Barati.
     8
     9        This is needed because LLIntAssembly.h is template generated from LowLevelInterpreter
     10        asm files, and may contain dead code which are harmless, but will trip up the warning.
     11        We should suppress the warning so that it doesn't break builds.
     12
     13        * llint/LowLevelInterpreter.cpp:
     14        (JSC::CLoop::execute):
     15
    1162018-10-03  Dan Bernstein  <mitz@apple.com>
    217

  • trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp

    r236381 r236813  
    447447        // LowLevelInterpreter.asm and its peers.
    448448
     449        IGNORE_CLANG_WARNINGS_BEGIN("unreachable-code")
    449450        #include "LLIntAssembly.h"
     451        IGNORE_CLANG_WARNINGS_END
    450452
    451453        OFFLINE_ASM_GLUE_LABEL(llint_return_to_host)
Note: See TracChangeset for help on using the changeset viewer.