Changeset 237137 in webkit


Ignore:
Timestamp:
Oct 15, 2018, 12:53:47 PM (7 years ago)
Author:
achristensen@apple.com
Message:

Remove unused WebFrame._loadType
https://bugs.webkit.org/show_bug.cgi?id=190583

Reviewed by Chris Dumez.

This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.

  • WebView/WebFrame.mm:

(toWebFrameLoadType): Deleted.
(-[WebFrame _loadType]): Deleted.

  • WebView/WebFramePrivate.h:
Location:
trunk/Source/WebKitLegacy/mac
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • TabularUnified trunk/Source/WebKitLegacy/mac/ChangeLog

    r237112 r237137  
     12018-10-15  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove unused WebFrame._loadType
     4        https://bugs.webkit.org/show_bug.cgi?id=190583
     5
     6        Reviewed by Chris Dumez.
     7
     8        This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
     9
     10        * WebView/WebFrame.mm:
     11        (toWebFrameLoadType): Deleted.
     12        (-[WebFrame _loadType]): Deleted.
     13        * WebView/WebFramePrivate.h:
     14
    1152018-10-15  Chris Dumez  <cdumez@apple.com>
    216
  • TabularUnified trunk/Source/WebKitLegacy/mac/WebView/WebFrame.mm

    r237112 r237137  
    10621062}
    10631063
    1064 static WebFrameLoadType toWebFrameLoadType(FrameLoadType frameLoadType)
    1065 {
    1066     switch (frameLoadType) {
    1067     case FrameLoadType::Standard:
    1068         return WebFrameLoadTypeStandard;
    1069     case FrameLoadType::Back:
    1070         return WebFrameLoadTypeBack;
    1071     case FrameLoadType::Forward:
    1072         return WebFrameLoadTypeForward;
    1073     case FrameLoadType::IndexedBackForward:
    1074         return WebFrameLoadTypeIndexedBackForward;
    1075     case FrameLoadType::Reload:
    1076         return WebFrameLoadTypeReload;
    1077     case FrameLoadType::Same:
    1078         return WebFrameLoadTypeSame;
    1079     case FrameLoadType::RedirectWithLockedBackForwardList:
    1080         return WebFrameLoadTypeInternal;
    1081     case FrameLoadType::Replace:
    1082         return WebFrameLoadTypeReplace;
    1083     case FrameLoadType::ReloadFromOrigin:
    1084         return WebFrameLoadTypeReloadFromOrigin;
    1085     case FrameLoadType::ReloadExpiredOnly:
    1086         ASSERT_NOT_REACHED();
    1087         return WebFrameLoadTypeReload;
    1088     }
    1089 }
    1090 
    1091 - (WebFrameLoadType)_loadType
    1092 {
    1093     return toWebFrameLoadType(_private->coreFrame->loader().loadType());
    1094 }
    1095 
    10961064#if PLATFORM(IOS)
    10971065- (BOOL)needsLayout
  • TabularUnified trunk/Source/WebKitLegacy/mac/WebView/WebFramePrivate.h

    r215724 r237137  
    6868extern NSString *WebFrameCanSuspendActiveDOMObjects;
    6969
    70 typedef enum {
    71     WebFrameLoadTypeStandard,
    72     WebFrameLoadTypeBack,
    73     WebFrameLoadTypeForward,
    74     WebFrameLoadTypeIndexedBackForward, // a multi-item hop in the backforward list
    75     WebFrameLoadTypeReload,
    76     WebFrameLoadTypeReloadAllowingStaleData,
    77     WebFrameLoadTypeSame,               // user loads same URL again (but not reload button)
    78     WebFrameLoadTypeInternal,           // maps to WebCore::FrameLoadTypeRedirectWithLockedBackForwardList
    79     WebFrameLoadTypeReplace,
    80     WebFrameLoadTypeReloadFromOrigin,
    81 } WebFrameLoadType;
    82 
    8370@interface WebFrame (WebPrivate)
    8471
     
    9380- (BOOL)_firstLayoutDone;
    9481- (BOOL)_isVisuallyNonEmpty;
    95 - (WebFrameLoadType)_loadType;
    9682#if TARGET_OS_IPHONE
    9783- (BOOL)needsLayout; // Needed for Mail <rdar://problem/6228038>
Note: See TracChangeset for help on using the changeset viewer.