Changeset 238650 in webkit


Ignore:
Timestamp:
Nov 28, 2018, 5:22:19 PM (6 years ago)
Author:
mark.lam@apple.com
Message:

ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
​https://bugs.webkit.org/show_bug.cgi?id=192110
<rdar://problem/46317746>

Reviewed by Saam Barati.

Source/JavaScriptCore:

  • config.h:

Source/WTF:

Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be
defined in Platform.h because it is also needed in WebCore for the CSS JIT. Also
contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore
(and other projects) as well as JSC. Hence, there's no reason why
ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h.

  • wtf/Platform.h:
Location:
trunk/Source
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r238639 r238650  
     12018-11-28  Mark Lam  <mark.lam@apple.com>
     2
     3        ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
     4        https://bugs.webkit.org/show_bug.cgi?id=192110
     5        <rdar://problem/46317746>
     6
     7        Reviewed by Saam Barati.
     8
     9        * config.h:
     10
    1112018-11-28  Keith Rollin  <krollin@apple.com>
    212

  • trunk/Source/JavaScriptCore/config.h

    r238564 r238650  
    3838
    3939#include <wtf/DisallowCType.h>
    40 
    41 #if !defined(ENABLE_SEPARATED_WX_HEAP)
    42 #if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
    43 #define ENABLE_SEPARATED_WX_HEAP 1
    44 #else
    45 #define ENABLE_SEPARATED_WX_HEAP 0
    46 #endif
    47 #endif // !defined(ENABLE_SEPARATED_WX_HEAP)

  • trunk/Source/WTF/ChangeLog

    r238638 r238650  
     12018-11-28  Mark Lam  <mark.lam@apple.com>
     2
     3        ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
     4        https://bugs.webkit.org/show_bug.cgi?id=192110
     5        <rdar://problem/46317746>
     6
     7        Reviewed by Saam Barati.
     8
     9        Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be
     10        defined in Platform.h because it is also needed in WebCore for the CSS JIT.  Also
     11        contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore
     12        (and other projects) as well as JSC.  Hence, there's no reason why
     13        ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h.
     14
     15        * wtf/Platform.h:
     16
    1172018-11-28  Keith Rollin  <krollin@apple.com>
    218

  • trunk/Source/WTF/wtf/Platform.h

    r238615 r238650  
    966966#endif
    967967
     968#ifndef ENABLE_SEPARATED_WX_HEAP
     969#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
     970#define ENABLE_SEPARATED_WX_HEAP 1
     971#else
     972#define ENABLE_SEPARATED_WX_HEAP 0
     973#endif
     974#endif
     975
    968976/* Configure the interpreter */
    969977#if COMPILER(GCC_COMPATIBLE)
Note: See TracChangeset for help on using the changeset viewer.