Changeset 238746 in webkit

Timestamp:

Nov 30, 2018, 11:37:44 AM (6 years ago)

Author:

achristensen@apple.com

Message:

Remove unused WebProcessCreationParameters.uiProcessCookieStorageIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=192157

Reviewed by Chris Dumez.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebProcessCreationParameters.cpp (modified) (2 diffs)
• Shared/WebProcessCreationParameters.h (modified) (1 diff)
• UIProcess/Cocoa/WebProcessPoolCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-11-30  Alex Christensen  <achristensen@webkit.org>
+
+        Remove unused WebProcessCreationParameters.uiProcessCookieStorageIdentifier
+        https://bugs.webkit.org/show_bug.cgi?id=192157
+
+        Reviewed by Chris Dumez.
+
+        * Shared/WebProcessCreationParameters.cpp:
+        (WebKit::WebProcessCreationParameters::encode const):
+        (WebKit::WebProcessCreationParameters::decode):
+        * Shared/WebProcessCreationParameters.h:
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (WebKit::WebProcessPool::platformInitializeWebProcess):
+
 2018-11-30  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp

@@ -58 +58 @@
     encoder << javaScriptConfigurationDirectory;
     encoder << javaScriptConfigurationDirectoryExtensionHandle;
-#if PLATFORM(MAC)
-    encoder << uiProcessCookieStorageIdentifier;
-#endif
 #if PLATFORM(IOS_FAMILY)
     encoder << cookieStorageDirectoryExtensionHandle;
@@ -221 +218 @@
     parameters.javaScriptConfigurationDirectoryExtensionHandle = WTFMove(*javaScriptConfigurationDirectoryExtensionHandle);
 
-#if PLATFORM(MAC)
-    if (!decoder.decode(parameters.uiProcessCookieStorageIdentifier))
-        return false;
-#endif
 #if PLATFORM(IOS_FAMILY)
     

trunk/Source/WebKit/Shared/WebProcessCreationParameters.h

@@ -85 +85 @@
     String javaScriptConfigurationDirectory;
     SandboxExtension::Handle javaScriptConfigurationDirectoryExtensionHandle;
-#if PLATFORM(MAC)
-    Vector<uint8_t> uiProcessCookieStorageIdentifier;
-#endif
 #if PLATFORM(IOS_FAMILY)
     SandboxExtension::Handle cookieStorageDirectoryExtensionHandle;

trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

@@ -221 +221 @@
     parameters.networkATSContext = adoptCF(_CFNetworkCopyATSContext());
 
-#if PLATFORM(MAC)
-    ASSERT(parameters.uiProcessCookieStorageIdentifier.isEmpty());
-    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanAccessRawCookies));
-    parameters.uiProcessCookieStorageIdentifier = identifyingDataFromCookieStorage([[NSHTTPCookieStorage sharedHTTPCookieStorage] _cookieStorage]);
-#endif
 #if ENABLE(MEDIA_STREAM)
     // Allow microphone access if either preference is set because WebRTC requires microphone access.