Changeset 239035 in webkit

Timestamp:

Dec 10, 2018 10:06:37 AM (5 years ago)

Author:

ap@apple.com

Message:

Move ENABLE_SEC_ITEM_SHIM out of WebKit's config.h
​https://bugs.webkit.org/show_bug.cgi?id=192428

Reviewed by Tim Horton.

Source/WebKit:

• config.h:

Source/WTF:

• wtf/Platform.h:

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/Platform.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/config.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2018-12-10  Alexey Proskuryakov  <ap@apple.com>
+
+        Move ENABLE_SEC_ITEM_SHIM out of WebKit's config.h
+        https://bugs.webkit.org/show_bug.cgi?id=192428
+
+        Reviewed by Tim Horton.
+
+        * wtf/Platform.h:
+
 2018-12-10  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WTF/wtf/Platform.h

@@ -1449 +1449 @@
 #define HAVE_LINK_PREVIEW 1
 #endif
+
+#if PLATFORM(COCOA)
+/* FIXME: This is a USE style macro, as it triggers the use of CFURLConnection framework stubs. */
+/* FIXME: Is this still necessary? CFURLConnection isn't used on Cocoa platforms any more. */
+#define ENABLE_SEC_ITEM_SHIM 1
+#endif

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-12-10  Alexey Proskuryakov  <ap@apple.com>
+
+        Move ENABLE_SEC_ITEM_SHIM out of WebKit's config.h
+        https://bugs.webkit.org/show_bug.cgi?id=192428
+
+        Reviewed by Tim Horton.
+
+        * config.h:
+
 2018-12-10  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebKit/config.h

@@ -61 +61 @@
 #define PLUGIN_ARCHITECTURE(ARCH) (defined PLUGIN_ARCHITECTURE_##ARCH && PLUGIN_ARCHITECTURE_##ARCH)
 
-#ifndef ENABLE_SEC_ITEM_SHIM
-#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
-#define ENABLE_SEC_ITEM_SHIM 1
-#endif
-#endif
-
 // FIXME: We should work towards not using CredentialStorage in WebKit to not have problems with digest authentication.
 #ifndef USE_CREDENTIAL_STORAGE_WITH_NETWORK_SESSION