Changeset 239356 in webkit

Timestamp:

Dec 18, 2018, 3:02:16 PM (7 years ago)

Author:

achristensen@apple.com

Message:

Fix API test introduced in r239339 on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=192675

• TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(TEST):
The iOS implementation of the safe browsing warning is a little different.
It does some element creation when it is added to the window so it knows how big it is.
To test these elements, we need to simulate adding it to the window.
A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-12-18  Alex Christensen  <achristensen@webkit.org>
+
+        Fix API test introduced in r239339 on iOS.
+        https://bugs.webkit.org/show_bug.cgi?id=192675
+
+        * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+        (TEST):
+        The iOS implementation of the safe browsing warning is a little different.
+        It does some element creation when it is added to the window so it knows how big it is.
+        To test these elements, we need to simulate adding it to the window.
+        A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
+
 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm

@@ -319 +319 @@
         while (![webView _safeBrowsingWarning])
             TestWebKitAPI::Util::spinRunLoop();
+#if !PLATFORM(MAC)
+        [[webView _safeBrowsingWarning] didMoveToWindow];
+#endif
         visitUnsafeSite([webView _safeBrowsingWarning]);
         TestWebKitAPI::Util::run(&done);
@@ -327 +330 @@
         while (![webView _safeBrowsingWarning])
             TestWebKitAPI::Util::spinRunLoop();
+#if !PLATFORM(MAC)
+        [[webView _safeBrowsingWarning] didMoveToWindow];
+#endif
         return webView;
     };