Changeset 239455 in webkit

Timestamp:

Dec 20, 2018, 10:51:49 AM (6 years ago)

Author:

mark.lam@apple.com

Message:

Fix a typo in slow_path_construct_arityCheck and operationConstructArityCheck.
​https://bugs.webkit.org/show_bug.cgi?id=192939
<rdar://problem/46869516>

Reviewed by Keith Miller.

JSTests:

• stress/stack-overflow-frame-for-construct-arityCheck-should-use-construct-codeBlock.js: Added.

Source/JavaScriptCore:

• jit/JITOperations.cpp:
• runtime/CommonSlowPaths.cpp:

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/stack-overflow-frame-for-construct-arityCheck-should-use-construct-codeBlock.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/jit/JITOperations.cpp (modified) (1 diff)
• Source/JavaScriptCore/runtime/CommonSlowPaths.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2018-12-20  Mark Lam  <mark.lam@apple.com>
+
+        Fix a typo in slow_path_construct_arityCheck and operationConstructArityCheck.
+        https://bugs.webkit.org/show_bug.cgi?id=192939
+        <rdar://problem/46869516>
+
+        Reviewed by Keith Miller.
+
+        * stress/stack-overflow-frame-for-construct-arityCheck-should-use-construct-codeBlock.js: Added.
+
 2018-12-20  Tadeu Zagallo  <tzagallo@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-12-20  Mark Lam  <mark.lam@apple.com>
+
+        Fix a typo in slow_path_construct_arityCheck and operationConstructArityCheck.
+        https://bugs.webkit.org/show_bug.cgi?id=192939
+        <rdar://problem/46869516>
+
+        Reviewed by Keith Miller.
+
+        * jit/JITOperations.cpp:
+        * runtime/CommonSlowPaths.cpp:
+
 2018-12-20  Caio Lima  <ticaiolima@gmail.com>
 

trunk/Source/JavaScriptCore/jit/JITOperations.cpp

@@ -131 +131 @@
     int32_t missingArgCount = CommonSlowPaths::arityCheckFor(exec, *vm, CodeForConstruct);
     if (UNLIKELY(missingArgCount < 0)) {
-        CodeBlock* codeBlock = CommonSlowPaths::codeBlockFromCallFrameCallee(exec, CodeForCall);
+        CodeBlock* codeBlock = CommonSlowPaths::codeBlockFromCallFrameCallee(exec, CodeForConstruct);
         exec->convertToStackOverflowFrame(*vm, codeBlock);
         NativeCallFrameTracer tracer(vm, exec);

trunk/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp

@@ -195 +195 @@
     int slotsToAdd = CommonSlowPaths::arityCheckFor(exec, vm, CodeForConstruct);
     if (UNLIKELY(slotsToAdd < 0)) {
-        CodeBlock* codeBlock = CommonSlowPaths::codeBlockFromCallFrameCallee(exec, CodeForCall);
+        CodeBlock* codeBlock = CommonSlowPaths::codeBlockFromCallFrameCallee(exec, CodeForConstruct);
         exec->convertToStackOverflowFrame(vm, codeBlock);
         NativeCallFrameTracer tracer(&vm, exec);