Changeset 239748 in webkit

Timestamp:

Jan 8, 2019, 2:23:12 PM (6 years ago)

Author:

achristensen@apple.com

Message:

Fix more assertions after r239710
​https://bugs.webkit.org/show_bug.cgi?id=193237

• NetworkProcess/cache/NetworkCacheStorage.h:

(WebKit::NetworkCache::Storage::store):
Make default parameter an empty lambda instead of a null CompletionHandler.
This way it can be called once instead of thinking it has already been called.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/cache/NetworkCacheStorage.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-01-08  Alex Christensen  <achristensen@webkit.org>
+
+        Fix more assertions after r239710
+        https://bugs.webkit.org/show_bug.cgi?id=193237
+
+        * NetworkProcess/cache/NetworkCacheStorage.h:
+        (WebKit::NetworkCache::Storage::store):
+        Make default parameter an empty lambda instead of a null CompletionHandler.
+        This way it can be called once instead of thinking it has already been called.
+
 2019-01-08  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h

@@ -83 +83 @@
 
     using MappedBodyHandler = Function<void (const Data& mappedBody)>;
-    void store(const Record&, MappedBodyHandler&&, CompletionHandler<void(int)>&& = { });
+    void store(const Record&, MappedBodyHandler&&, CompletionHandler<void(int)>&& = [] (int) { });
 
     void remove(const Key&);