Changeset 239967 in webkit

Timestamp:

Jan 14, 2019 6:14:16 PM (5 years ago)

Author:

achristensen@apple.com

Message:

Bulgarian TLD should not punycode-encode URLs with Bulgarian Cyrillic characters
​https://bugs.webkit.org/show_bug.cgi?id=193411
<rdar://problem/47215929>

Reviewed by Alexey Proskuryakov.

Source/WTF:

• wtf/cocoa/NSURLExtras.mm:

(WTF::allCharactersAllowedByTLDRules):

LayoutTests:

• fast/url/user-visible/cyrillic-NFD-expected.txt:
• fast/url/user-visible/cyrillic-NFD.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/url/user-visible/cyrillic-NFD-expected.txt (modified) (1 diff)
• LayoutTests/fast/url/user-visible/cyrillic-NFD.html (modified) (1 diff)
• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/cocoa/NSURLExtras.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-01-14  Alex Christensen  <achristensen@webkit.org>
+
+        Bulgarian TLD should not punycode-encode URLs with Bulgarian Cyrillic characters
+        https://bugs.webkit.org/show_bug.cgi?id=193411
+        <rdar://problem/47215929>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * fast/url/user-visible/cyrillic-NFD-expected.txt:
+        * fast/url/user-visible/cyrillic-NFD.html:
+
 2019-01-14  John Wilander  <wilander@apple.com>
 

trunk/LayoutTests/fast/url/user-visible/cyrillic-NFD-expected.txt

@@ -6 +6 @@
 PASS test('http://спецодежда.онлайн/') is 'http://спецодежда.онлайн/'
 PASS test('http://спецодежда.онлайн/') is 'http://спецодежда.онлайн/'
+PASS test('http://ж1-2.бг/') is 'http://ж1-2.бг/'
+PASS test('http://жabc.бг/') is 'http://xn--abc-udd.xn--90ae/'
+PASS test('http://abc.бг/') is 'http://abc.xn--90ae/'
+PASS test('http://ы.бг/') is 'http://xn--01a.xn--90ae/'
+PASS test('http://э.бг/') is 'http://xn--21a.xn--90ae/'
 PASS successfullyParsed is true
 

trunk/LayoutTests/fast/url/user-visible/cyrillic-NFD.html

@@ -18 +18 @@
 shouldBe("test('http://спецодежда.онла\u0439н/')", "'http://спецодежда.онлайн/'");
 shouldBe("test('http://спецодежда.онла\u0438\u0306н/')", "'http://спецодежда.онлайн/'");
+shouldBe("test('http://ж1-2.бг/')", "'http://ж1-2.бг/'");
+shouldBe("test('http://жabc.бг/')", "'http://xn--abc-udd.xn--90ae/'");
+shouldBe("test('http://abc.бг/')", "'http://abc.xn--90ae/'");
+shouldBe("test('http://ы.бг/')", "'http://xn--01a.xn--90ae/'");
+shouldBe("test('http://э.бг/')", "'http://xn--21a.xn--90ae/'");
 
 </script>

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-01-14  Alex Christensen  <achristensen@webkit.org>
+
+        Bulgarian TLD should not punycode-encode URLs with Bulgarian Cyrillic characters
+        https://bugs.webkit.org/show_bug.cgi?id=193411
+        <rdar://problem/47215929>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * wtf/cocoa/NSURLExtras.mm:
+        (WTF::allCharactersAllowedByTLDRules):
+
 2019-01-12  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm

@@ -541 +541 @@
     });
 
+    // https://www.icann.org/sites/default/files/packages/lgr/lgr-second-level-bulgarian-30aug16-en.html
+    static const UChar cyrillicBG[] = {
+        '.',
+        0x0431, // CYRILLIC SMALL LETTER BE
+        0x0433 // CYRILLIC SMALL LETTER GHE
+    };
+    CHECK_RULES_IF_SUFFIX_MATCHES(cyrillicBG, [](UChar ch) {
+        return (ch >= 0x0430 && ch <= 0x044A) || ch == 0x044C || (ch >= 0x044E && ch <= 0x0450) || ch == 0x045D || isASCIIDigit(ch) || ch == '-';
+    });
+
     // Not a known top level domain with special rules.
     return NO;