Changeset 240094 in webkit

Timestamp:

Jan 16, 2019, 4:20:11 PM (6 years ago)

Author:

achristensen@apple.com

Message:

sendBeacon to previously-unvisited https domain always fails
​https://bugs.webkit.org/show_bug.cgi?id=193508

Reviewed by Geoffrey Garen.

• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::didReceiveChallenge):
If a ping load is doing a TLS handshake, continue if the server has good certificates.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/PingLoad.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-01-16  Alex Christensen  <achristensen@webkit.org>
+
+        sendBeacon to previously-unvisited https domain always fails
+        https://bugs.webkit.org/show_bug.cgi?id=193508
+
+        Reviewed by Geoffrey Garen.
+
+        * NetworkProcess/PingLoad.cpp:
+        (WebKit::PingLoad::didReceiveChallenge):
+        If a ping load is doing a TLS handshake, continue if the server has good certificates.
+
 2019-01-16  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/NetworkProcess/PingLoad.cpp

@@ -118 +118 @@
 }
 
-void PingLoad::didReceiveChallenge(AuthenticationChallenge&&, ChallengeCompletionHandler&& completionHandler)
+void PingLoad::didReceiveChallenge(AuthenticationChallenge&& challenge, ChallengeCompletionHandler&& completionHandler)
 {
     RELEASE_LOG_IF_ALLOWED("didReceiveChallenge");
+    if (challenge.protectionSpace().authenticationScheme() == ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested) {
+        completionHandler(AuthenticationChallengeDisposition::PerformDefaultHandling, { });
+        return;
+    }
     auto weakThis = makeWeakPtr(*this);
     completionHandler(AuthenticationChallengeDisposition::Cancel, { });