Changeset 240520 in webkit


Ignore:
Timestamp:
Jan 25, 2019 3:41:30 PM (5 years ago)
Author:
achristensen@apple.com
Message:

Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess
​https://bugs.webkit.org/show_bug.cgi?id=193844

Reviewed by Andy Estes.

Source/WebCore/PAL:

  • pal/spi/mac/HIServicesSPI.h:

Source/WebKit:

This simplifies ChildProcess and removes NetworkProcess-specific code from this generic abstraction.

  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::initializeProcess):

  • Shared/ios/ChildProcessIOS.mm:

(WebKit::ChildProcess::setApplicationIsDaemon): Deleted.

  • Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::setApplicationIsDaemon): Deleted.

Location:
trunk/Source
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/PAL/ChangeLog

    r240494 r240520  
     12019-01-25  Alex Christensen  <achristensen@webkit.org>
     2
     3        Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess
     4        https://bugs.webkit.org/show_bug.cgi?id=193844
     5
     6        Reviewed by Andy Estes.
     7
     8        * pal/spi/mac/HIServicesSPI.h:
     9
    1102019-01-25  David Kilzer  <ddkilzer@apple.com>
    211

  • trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h

    r240211 r240520  
    124124OSStatus CoreDragSetImage(CoreDragRef, CGPoint imageOffset, CoreDragImageSpec*, CGSRegionObj imageShape, float overallAlpha);
    125125const UInt8* AXTextMarkerGetBytePtr(AXTextMarkerRef);
     126OSStatus SetApplicationIsDaemon(Boolean);
    126127
    127128WTF_EXTERN_C_END

  • trunk/Source/WebKit/ChangeLog

    r240517 r240520  
     12019-01-25  Alex Christensen  <achristensen@webkit.org>
     2
     3        Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess
     4        https://bugs.webkit.org/show_bug.cgi?id=193844
     5
     6        Reviewed by Andy Estes.
     7
     8        This simplifies ChildProcess and removes NetworkProcess-specific code from this generic abstraction.
     9
     10        * NetworkProcess/mac/NetworkProcessMac.mm:
     11        (WebKit::NetworkProcess::initializeProcess):
     12        * Shared/ios/ChildProcessIOS.mm:
     13        (WebKit::ChildProcess::setApplicationIsDaemon): Deleted.
     14        * Shared/mac/ChildProcessMac.mm:
     15        (WebKit::ChildProcess::setApplicationIsDaemon): Deleted.
     16
    1172019-01-25  Keith Rollin  <krollin@apple.com>
    218

  • trunk/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm

    r240437 r240520  
    4343#import <pal/spi/cf/CFNetworkSPI.h>
    4444#import <pal/spi/cocoa/LaunchServicesSPI.h>
     45#import <pal/spi/mac/HIServicesSPI.h>
    4546#import <sysexits.h>
    4647#import <wtf/FileSystem.h>
    … …  
    5354void NetworkProcess::initializeProcess(const ChildProcessInitializationParameters&)
    5455{
     56#if PLATFORM(MAC) && !PLATFORM(IOSMAC)
    5557    // Having a window server connection in this process would result in spin logs (<rdar://problem/13239119>).
    56     setApplicationIsDaemon();
     58    OSStatus error = SetApplicationIsDaemon(true);
     59    ASSERT_UNUSED(error, error == noErr);
     60#endif
     61
     62    launchServicesCheckIn();
    5763}
    5864

  • trunk/Source/WebKit/Shared/ios/ChildProcessIOS.mm

    r240437 r240520  
    4646
    4747namespace WebKit {
    48 
    49 void ChildProcess::setApplicationIsDaemon()
    50 {
    51 }
    5248
    5349void ChildProcess::platformInitialize()

  • trunk/Source/WebKit/Shared/mac/ChildProcessMac.mm

    r240437 r240520  
    7777extern "C" CFDictionaryRef _LSApplicationCheckIn(LSSessionID sessionID, CFDictionaryRef applicationInfo);
    7878
    79 extern "C" OSStatus SetApplicationIsDaemon(Boolean isDaemon);
    80 
    81 
    8279namespace WebKit {
    8380using namespace WebCore;
    … …  
    153150}
    154151
    155 void ChildProcess::setApplicationIsDaemon()
    156 {
    157 #if !PLATFORM(IOSMAC)
    158     OSStatus error = SetApplicationIsDaemon(true);
    159     ASSERT_UNUSED(error, error == noErr);
    160 #endif
    161 
    162     // FIXME: Is this needed in iOSMac?
    163     launchServicesCheckIn();
    164 }
    165 
    166152void ChildProcess::launchServicesCheckIn()
    167153{
Note: See TracChangeset for help on using the changeset viewer.