Changeset 242895 in webkit


Ignore:
Timestamp:
Mar 13, 2019 11:45:31 AM (5 years ago)
Author:
achristensen@apple.com
Message:

Prevent checked_cf_cast crashes in ResourceResponse::platformCertificateInfo
​https://bugs.webkit.org/show_bug.cgi?id=195686

Reviewed by Tim Horton.

This covers up a type confusion bug on some OSes until rdar://problem/48853137 is resolved.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/cocoa/ResourceResponseCocoa.mm:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r242894 r242895  
     12019-03-13  Alex Christensen  <achristensen@webkit.org>
     2
     3        Prevent checked_cf_cast crashes in ResourceResponse::platformCertificateInfo
     4        https://bugs.webkit.org/show_bug.cgi?id=195686
     5
     6        Reviewed by Tim Horton.
     7
     8        This covers up a type confusion bug on some OSes until rdar://problem/48853137 is resolved.
     9
     10        * SourcesCocoa.txt:
     11        * WebCore.xcodeproj/project.pbxproj:
     12        * platform/network/cocoa/ResourceResponseCocoa.mm:
     13
    1142019-03-13  Thibault Saunier  <tsaunier@igalia.com>
    215

  • trunk/Source/WebCore/SourcesCocoa.txt

    r242766 r242895  
    520520platform/network/cocoa/ProtectionSpaceCocoa.mm
    521521platform/network/cocoa/ResourceRequestCocoa.mm
    522 platform/network/cocoa/ResourceResponseCocoa.mm
     522platform/network/cocoa/ResourceResponseCocoa.mm @no-unify // Unsafe to unify until rdar://problem/48853137 is resolved
    523523platform/network/cocoa/WebCoreNSURLSession.mm @no-unify
    524524

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r242840 r242895  
    19161916                5B30695D18B3D3450099D5E8 /* WebGLDrawBuffers.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5B30695A18B3D3450099D5E8 /* WebGLDrawBuffers.cpp */; };
    19171917                5B30695E18B3D3450099D5E8 /* WebGLDrawBuffers.h in Headers */ = {isa = PBXBuildFile; fileRef = 5B30695B18B3D3450099D5E8 /* WebGLDrawBuffers.h */; };
     1918                5C2B1AEC22397EBC00B91CF7 /* ResourceResponseCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = A1F78D0B1C25422C00245446 /* ResourceResponseCocoa.mm */; };
    19181919                5C4304B0191AC908000E2BC0 /* EXTShaderTextureLOD.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5C4304AD191AC908000E2BC0 /* EXTShaderTextureLOD.cpp */; };
    19191920                5C4304B1191AC908000E2BC0 /* EXTShaderTextureLOD.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4304AE191AC908000E2BC0 /* EXTShaderTextureLOD.h */; };
    … …  
    3306133062                                CDA29A161CBDA56C00901CCF /* PlaybackSessionInterfaceMac.mm in Sources */,
    3306233063                                419242492127B93E00634FCF /* RealtimeOutgoingVideoSourceCocoa.mm in Sources */,
     33064                                5C2B1AEC22397EBC00B91CF7 /* ResourceResponseCocoa.mm in Sources */,
    3306333065                                316DCB8A1E7A6996001B5F87 /* RTCIceTransport.cpp in Sources */,
    3306433066                                BC51156E12B1749C00C96754 /* ScrollAnimatorMac.mm in Sources */,

  • trunk/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm

    r241220 r242895  
    112112}
    113113
    114 static CFStringRef const commonHeaderFields[] = {
    115     CFSTR("Age"), CFSTR("Cache-Control"), CFSTR("Content-Type"), CFSTR("Date"), CFSTR("Etag"), CFSTR("Expires"), CFSTR("Last-Modified"), CFSTR("Pragma")
    116 };
    117 
    118114NSURLResponse *ResourceResponse::nsURLResponse() const
    119115{
Note: See TracChangeset for help on using the changeset viewer.