Changeset 243946 in webkit


Ignore:
Timestamp:
Apr 5, 2019, 2:50:06 PM (6 years ago)
Author:
achristensen@apple.com
Message:

Flaky API Test TestWebKitAPI.WebKit.PerformedActionForURL
https://bugs.webkit.org/show_bug.cgi?id=196151

Reviewed by Chris Dumez.

  • TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:

(TEST):
We were assuming that messages were received in a certain order.
Actually wait for all messages to be received before checking results.

Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/safari-607-branch/Tools/ChangeLog

    r243882 r243946  
     12019-04-05  Alex Christensen  <achristensen@webkit.org>
     2
     3        Flaky API Test TestWebKitAPI.WebKit.PerformedActionForURL
     4        https://bugs.webkit.org/show_bug.cgi?id=196151
     5
     6        Reviewed by Chris Dumez.
     7
     8        * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
     9        (TEST):
     10        We were assuming that messages were received in a certain order.
     11        Actually wait for all messages to be received before checking results.
     12
    1132019-04-04  Kocsen Chung  <kocsen_chung@apple.com>
    214
  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm

    r243319 r243946  
    169169    [webView loadHTMLString:@"<script>fetch('notify').then(function(){fetch('block').then().catch(function(){alert('test complete')})})</script>" baseURL:[NSURL URLWithString:@"apitest:///"]];
    170170    TestWebKitAPI::Util::run(&receivedAlert);
    171    
     171    while (notificationList.size() < 2)
     172        TestWebKitAPI::Util::spinRunLoop();
     173
    172174    Vector<Notification> expectedNotifications {
    173175        { "firstList", "apitest:///notify", false, false, false, { "testnotification" } },
Note: See TracChangeset for help on using the changeset viewer.