Changeset 244654 in webkit

Timestamp:

Apr 25, 2019 11:15:47 AM (5 years ago)

Author:

achristensen@apple.com

Message:

Revert some code accidentally committed with r244653
​https://bugs.webkit.org/show_bug.cgi?id=197131

• TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:

(TestWebKitAPI::TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-25  Alex Christensen  <achristensen@webkit.org>
+
+        Revert some code accidentally committed with r244653
+        https://bugs.webkit.org/show_bug.cgi?id=197131
+
+        * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
+        (TestWebKitAPI::TEST):
+
 2019-04-25  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm

@@ -28 +28 @@
 #import "TCPServer.h"
 #import "Utilities.h"
-#import <WebKit/WKProcessPoolPrivate.h>
 #import <WebKit/WKWebsiteDataStorePrivate.h>
 #import <WebKit/WebKit.h>
-#import <WebKit/_WKProcessPoolConfiguration.h>
 #import <WebKit/_WKWebsiteDataStoreConfiguration.h>
 #import <wtf/RetainPtr.h>
@@ -67 +65 @@
         const char* reply = ""
         "HTTP/1.1 200 OK\r\n"
-        "Strict-Transport-Security: max-age=16070400; includeSubDomains\r\n"
         "Content-Length: 34\r\n\r\n"
         "<script>alert('success!')</script>";
@@ -74 +71 @@
     });
 
-    RetainPtr<NSString> tempDir = NSTemporaryDirectory();
-    WTFLogAlways("ORIGINAL TEMP DIR %@", tempDir.get());
-    if ([tempDir hasSuffix:@"/"])
-        tempDir = [tempDir substringWithRange:NSMakeRange(0, [tempDir length] - 1)];
-    
-    WTFLogAlways("TEMP DIR %@", tempDir.get());
-    auto poolConfiguration = adoptNS([_WKProcessPoolConfiguration new]);
-    [poolConfiguration setHSTSStorageDirectory:tempDir.get()];
     auto storeConfiguration = adoptNS([_WKWebsiteDataStoreConfiguration new]);
     [storeConfiguration setHTTPSProxy:[NSURL URLWithString:[NSString stringWithFormat:@"https://127.0.0.1:%d/", server.port()]]];
     auto viewConfiguration = adoptNS([WKWebViewConfiguration new]);
     [viewConfiguration setWebsiteDataStore:[[[WKWebsiteDataStore alloc] _initWithConfiguration:storeConfiguration.get()] autorelease]];
-    [viewConfiguration setProcessPool:[[[WKProcessPool alloc] _initWithConfiguration:poolConfiguration.get()] autorelease]];
     auto webView = adoptNS([[WKWebView alloc] initWithFrame:CGRectMake(0, 0, 100, 100) configuration:viewConfiguration.get()]);
     auto delegate = adoptNS([ProxyDelegate new]);
@@ -94 +82 @@
     [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"https://example.com/"]]];
     TestWebKitAPI::Util::run(&receivedAlert);
-    
-    RetainPtr<NSString> filePath = [tempDir stringByAppendingPathComponent:@"HSTS.plist"];
-    WTFLogAlways("WAITING FOR FILE TO BE WRITTEN TO %@", filePath.get());
-    while (![[NSFileManager defaultManager] fileExistsAtPath:filePath.get()])
-        TestWebKitAPI::Util::spinRunLoop();
-    [[NSFileManager defaultManager] removeItemAtPath:filePath.get() error:nil];
-    WTFLogAlways("DONE");
 }