Changeset 247231 in webkit


Ignore:
Timestamp:
Jul 8, 2019 3:59:11 PM (5 years ago)
Author:
achristensen@apple.com
Message:

Prevent null dereferencing in SubresourceLoader::init's lambda
https://bugs.webkit.org/show_bug.cgi?id=199580

Reviewed by Ryosuke Niwa.

Crash logs indicate that sometimes m_documentLoader is null.
This is similar to https://bugs.webkit.org/show_bug.cgi?id=187360

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::init):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r247222 r247231  
     12019-07-08  Alex Christensen  <achristensen@webkit.org>
     2
     3        Prevent null dereferencing in SubresourceLoader::init's lambda
     4        https://bugs.webkit.org/show_bug.cgi?id=199580
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Crash logs indicate that sometimes m_documentLoader is null.
     9        This is similar to https://bugs.webkit.org/show_bug.cgi?id=187360
     10
     11        * loader/SubresourceLoader.cpp:
     12        (WebCore::SubresourceLoader::init):
     13
    1142019-07-08  Wenson Hsieh  <wenson_hsieh@apple.com>
    215
  • trunk/Source/WebCore/loader/SubresourceLoader.cpp

    r245508 r247231  
    165165        if (!initialized)
    166166            return completionHandler(false);
     167        if (!m_documentLoader) {
     168            ASSERT_NOT_REACHED();
     169            RELEASE_LOG_ERROR(ResourceLoading, "SubresourceLoader::init: resource load canceled because document loader is null (frame = %p, frameLoader = %p, resourceID = %lu)", frame(), frameLoader(), identifier());
     170            return completionHandler(false);
     171        }
    167172        ASSERT(!reachedTerminalState());
    168173        m_state = Initialized;
Note: See TracChangeset for help on using the changeset viewer.