Changeset 249612 in webkit


Ignore:
Timestamp:
Sep 7, 2019 7:53:21 AM (5 years ago)
Author:
mark.lam@apple.com
Message:

The jsc shell should allow disabling of the Gigacage for testing purposes.
​https://bugs.webkit.org/show_bug.cgi?id=201579

Reviewed by Michael Saboff.

JSTests:

Unskip the tests now.

  • stress/disable-gigacage-arrays.js:
  • stress/disable-gigacage-strings.js:
  • stress/disable-gigacage-typed-arrays.js:

Source/JavaScriptCore:

Check for the same GIGACAGE_ENABLED env var that is checked by Gigacage code. If
this env var is present and it has a falsy value, then do not
forbidDisablingPrimitiveGigacage() in the jsc shell.

  • jsc.cpp:

(jscmain):

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/JSTests/ChangeLog

    r249611 r249612  
     12019-09-07  Mark Lam  <mark.lam@apple.com>
     2
     3        The jsc shell should allow disabling of the Gigacage for testing purposes.
     4        https://bugs.webkit.org/show_bug.cgi?id=201579
     5
     6        Reviewed by Michael Saboff.
     7
     8        Unskip the tests now.
     9
     10        * stress/disable-gigacage-arrays.js:
     11        * stress/disable-gigacage-strings.js:
     12        * stress/disable-gigacage-typed-arrays.js:
     13
    1142019-09-07  Mark Lam  <mark.lam@apple.com>
    215

  • trunk/JSTests/stress/disable-gigacage-arrays.js

    r249611 r249612  
    1 //@ skip
    2 // temporarily disable, previous options: runNoisyTestWithEnv "disable-gigacage", "GIGACAGE_ENABLED=0"
     1//@ runNoisyTestWithEnv "disable-gigacage", "GIGACAGE_ENABLED=0"
    32
    43(function() {

  • trunk/JSTests/stress/disable-gigacage-strings.js

    r249611 r249612  
    1 //@ skip
    2 // temporarily disable, previous options: runNoisyTestWithEnv "disable-gigacage", "GIGACAGE_ENABLED=0"
     1//@ runNoisyTestWithEnv "disable-gigacage", "GIGACAGE_ENABLED=0"
    32
    43(function() {

  • trunk/JSTests/stress/disable-gigacage-typed-arrays.js

    r249611 r249612  
    1 //@ skip
    2 // temporarily disable, previous options: runNoisyTestWithEnv "disable-gigacage", "GIGACAGE_ENABLED=0"
     1//@ runNoisyTestWithEnv "disable-gigacage", "GIGACAGE_ENABLED=0"
    32
    43(function() {

  • trunk/Source/JavaScriptCore/ChangeLog

    r249608 r249612  
     12019-09-07  Mark Lam  <mark.lam@apple.com>
     2
     3        The jsc shell should allow disabling of the Gigacage for testing purposes.
     4        https://bugs.webkit.org/show_bug.cgi?id=201579
     5
     6        Reviewed by Michael Saboff.
     7
     8        Check for the same GIGACAGE_ENABLED env var that is checked by Gigacage code.  If
     9        this env var is present and it has a falsy value, then do not
     10        forbidDisablingPrimitiveGigacage() in the jsc shell.
     11
     12        * jsc.cpp:
     13        (jscmain):
     14
    1152019-09-06  Mark Lam  <mark.lam@apple.com>
    216

  • trunk/Source/JavaScriptCore/jsc.cpp

    r249608 r249612  
    30873087    JSC::Wasm::enableFastMemory();
    30883088#endif
    3089     Gigacage::forbidDisablingPrimitiveGigacage();
     3089
     3090    bool gigacageDisableRequested = false;
     3091#if GIGACAGE_ENABLED && !COMPILER(MSVC)
     3092    if (char* gigacageEnabled = getenv("GIGACAGE_ENABLED")) {
     3093        if (!strcasecmp(gigacageEnabled, "no") || !strcasecmp(gigacageEnabled, "false") || !strcasecmp(gigacageEnabled, "0"))
     3094            gigacageDisableRequested = true;
     3095    }
     3096#endif
     3097    if (!gigacageDisableRequested)
     3098        Gigacage::forbidDisablingPrimitiveGigacage();
    30903099
    30913100#if PLATFORM(COCOA)
Note: See TracChangeset for help on using the changeset viewer.